Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #993 user name field consistency #1043

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix: #993 user name field consistency #1043

merged 2 commits into from
Nov 21, 2023

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Nov 17, 2023 •
edited
Loading

For task #993

  • Align user_name and userId to max length 20 (frontend already has 20 in max). IDIM doc has the max as 20.
  • Changes are on router_idim_proxy.py and schemas.py, others just some formatting adjustment.

@sonarqubecloud SonarQubeCloud
Copy link

[nr-forests-access-management_admin] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review November 20, 2023 17:52
@ianliuwk1019 ianliuwk1019 merged commit f0f573d into main Nov 21, 2023
11 checks passed
@ianliuwk1019 ianliuwk1019 deleted the fix/993-user-name-field-consistency branch November 21, 2023 18:09
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Merged
NickSaglioni pushed a commit that referenced this pull request Dec 5, 2023
@ianliuwk1019
fix: #993 user name field consistency (#1043)
b5a3e52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MCatherine1994 MCatherine1994 MCatherine1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianliuwk1019 @MCatherine1994