Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #1046 add test for admin management endpoints #1055

Merged
merged 22 commits into from
Nov 28, 2023
Merged

feat: #1046 add test for admin management endpoints #1055

merged 22 commits into from
Nov 28, 2023

Conversation

MCatherine1994
Copy link
Contributor

No description provided.

@MCatherine1994
feat(885): added create application method, add both coding pattern f…
b592bed 
…or team discussion, add router guard for checking permission and not allow self grant, refs: #885
@MCatherine1994
cleanup(885): remove crud methods, refs: #885
79474e0
@MCatherine1994
feat(885): add deletion endpoint for admin management, refs: #885
808ef37
@MCatherine1994
feat(885): add get endpooint for admin manageent, refs: #885
e975a64
@MCatherine1994
feat(885): add audit log for creating and deleting application admin,…
90b6826 
… refs: #885
@MCatherine1994
feat(885): remove get admin by user, add get admin by app, refs: #885
345af3f
@MCatherine1994
cleanup(885): remove unused endpoint, refs: #885
6ff37ae
@MCatherine1994
fix(885): merge audit if statement to solve code smell, refs: #885
63a419e
@MCatherine1994
Merge branch 'main' of https://github.com/bcgov/nr-forests-access-man…
2c04b74 
…agement into feat/885-add-admin-endpoint
@MCatherine1994
fix(885): fix username str constrains, refs: #885
95ebcfe
@MCatherine1994
cleanup(885): remove unused method, refs: #885
940feb2
@MCatherine1994
cleanup(885): cleanup code fix comments, logs, refs: #885
896f73c
@MCatherine1994
feat(885): add router guard to check if application admin id exists, …
369f55c 
…refs: #885
@MCatherine1994
feat(885): add router guard to check application exists, refs: #885
f681311
@MCatherine1994
test(1046): add repository and service test for admin management api,…
14cc186 
… refs: #1046
@MCatherine1994
merge(1046): merge from main, refs: #1046
5063cfd
@MCatherine1994
Merge branch 'main' of https://github.com/bcgov/nr-forests-access-man…
82b4c87 
…agement into feat/1046-admin-managemet-test
@MCatherine1994
feat(1046): add router test for admin management endpoint, refs: #1046
9baf93f
@MCatherine1994
feat(1046): add router test for admin management endpoint, refs: #1046
e0e33b8
@MCatherine1994
fix(1046): fix test error for get endpoint, refs: #1046
5872636
basilv
basilv reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@basilv basilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR says it is adding tests, but there's a router/service/repo changes.

basilv
basilv previously approved these changes Nov 28, 2023
View reviewed changes
ianliuwk1019
ianliuwk1019 previously approved these changes Nov 28, 2023
View reviewed changes
@MCatherine1994 MCatherine1994 dismissed stale reviews from ianliuwk1019 and basilv via d320400 November 28, 2023 19:46
@sonarqubecloud SonarQubeCloud
Copy link

[nr-forests-access-management_admin] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MCatherine1994 MCatherine1994 merged commit 7e39737 into main Nov 28, 2023
10 checks passed
@MCatherine1994 MCatherine1994 deleted the feat/1046-admin-managemet-test branch November 28, 2023 20:01
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Merged
NickSaglioni pushed a commit that referenced this pull request Dec 5, 2023
@MCatherine1994
feat: #1046 add test for admin management endpoints (#1055)
3e41d03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianliuwk1019 ianliuwk1019 ianliuwk1019 approved these changes

@basilv basilv basilv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MCatherine1994 @basilv @ianliuwk1019