-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #888 transfer to admin table #1068
Conversation
server/flyway/sql/V34__migrate_fam_role_assignment_to_admin_table.sql
Outdated
Show resolved
Hide resolved
I tested the new flyway script locally, and if we feel it looks correct, I'll run in tools space first. |
server/admin_management/tests/routers/test_application_admin_router.py
Outdated
Show resolved
Hide resolved
server/flyway/sql/V34__migrate_fam_role_assignment_to_admin_table.sql
Outdated
Show resolved
Hide resolved
Hope I am wrong, or maybe I am just confused myself, but would still like to ask this question: Although if this PR is good, should this PR be pending for merge until either "frontend" or somehow "backend api" starts directing "role assignment" for "xyz_ACCESS_ADMIN" role to the new "fam_application_admin" table first? |
Agree somewhat with Ian that we can't release this functionality until the rest of it is done. We could merge this and deploy to dev, understanding that we will no longer be able to add admins in dev until the rest of the associated changes are done. (we can add admins, but will be in the wrong table and this won't be used to determine authentication). |
I agree Ian's point. I think we can cut a release today without merge this one, and let the work we have done go to prod. We haven't do any prod deployment recently. Once we cut a release, we can merge this one to dev, and work on frontend implementation next sprint, and deploy them together later. |
…ole to be admin, refs: #888
…agement into feat/888-transfer-to-admin-table
[nr-forests-access-management_admin] Kudos, SonarCloud Quality Gate passed! |
refs: #888