feat: #1626 Add tests pagination user role assignment endpoint #1646

ianliuwk1019 · 2024-11-04T21:18:16Z

Closes #1631

Use "create_date" as default sorting.
Return "create_date" for Get application-user-role-assignment endpoint.
Generalized sorting into paginate_service.
Use func.utcnow() instead of func.utcnow() to prevent using "fixed" time during model loading at FamUserRoleXref for now.
Re-gen client-code for application-user-role-assignment for frontend.
Add tests for paginate_service, crud_application.get_application_role_assignments and router_application GET "/{application_id}/user-role-assignment" endpoint for scenarios.

…r backend pagination.

…endpoint

…o prevent date is fixed at load time.

server/backend/api/app/crud/services/paginate_service.py

server/backend/api/app/models/model.py

server/backend/api/app/schemas/pagination.py

craigyu

Nicely done! Just added one question for one of the test files server/backend/testspg/crud/services/test_paginate_service.py

server/backend/api/app/crud/crud_application.py

server/backend/testspg/crud/services/test_paginate_service.py

…-tests-pagination-user_role_assignment-endpoint

sonarqubecloud · 2024-11-14T22:21:00Z

Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ianliuwk1019 added 30 commits October 14, 2024 17:47

Reconfig application router using dash for endpoint.

7263c7a

Fix tests for router endpoint change.

1ca7282

add python-generics

c689e29

Add paged result schema

3063fca

Use pydantic object for Fast API query params.

089856c

Add pagination fields description.

96a72a4

Add draft service

dceb790

Call paginate_service for application user role endpoint.

418b0ae

Adjust MAX_PAGE_SIZE to 100000 temporary due to frontend not ready fo…

0a2d779

…r backend pagination.

Client-Code gen

7cb2c68

Add sorting function

4f2b2f4

Minor naming refactoring.

72f3470

Add search param

f174292

Add filter function

7b31342

use ilike and add header

fa56f0f

Add comments

5799d62

Minor comment/function adjustment

7a4cc05

Remove GenericModel and use BaseModel

271c0cb

Add back missed base filter.

f396381

Fix total count query.

1cf74e8

Merge branch 'main' into feat/1626-paginate-get-user_role_assignment-…

c72931c

…endpoint

Fix tests.

49c87a0

Abstract class for PageParamsSchema

c060322

Remove unused python generic

e2d82af

Add comments.

30032d6

Add PageResultMetaSchema for pagination meta data.

9a87f9d

Add first default test and fixture.

49defd3

Add test

8aaaa9a

Minor refactoring.

9431b78

Generalized sort_by into paginate_service

f4d8078

ianliuwk1019 added 13 commits October 29, 2024 12:42

Add filtering test

9c7af0f

Add router tests

82a8af9

Add pagination tests for crud_application

a23051e

Add filter tests

9d6779b

Add few conditions for tests

1f38353

Add "UPDATED_DATE" as default and change model to use func.utcnow() t…

3cd1f2c

…o prevent date is fixed at load time.

Fix broken tests due to schema change.

da560c9

update client-code-gen

9cd5f83

Add some comments

aa6376d

Use create_date for default sorting instead of update_date.

8fe9354

Add test to validate pagination default values

1847a6c

Client code gen for pagination default create_date.

4eff461

Use datetime formate as constant

33656f6

ianliuwk1019 commented Nov 4, 2024

View reviewed changes

server/backend/api/app/crud/services/paginate_service.py Show resolved Hide resolved

ianliuwk1019 commented Nov 4, 2024

View reviewed changes

server/backend/api/app/models/model.py Show resolved Hide resolved

ianliuwk1019 commented Nov 4, 2024

View reviewed changes

server/backend/api/app/schemas/pagination.py Show resolved Hide resolved

Minor refactoring.

5926305

ianliuwk1019 marked this pull request as ready for review November 5, 2024 00:19

ianliuwk1019 requested a review from craigyu November 5, 2024 00:20

craigyu reviewed Nov 14, 2024

View reviewed changes

server/backend/api/app/crud/crud_application.py Show resolved Hide resolved

server/backend/testspg/crud/services/test_paginate_service.py Show resolved Hide resolved

server/backend/testspg/crud/services/test_paginate_service.py Show resolved Hide resolved

Defaut create_date sorting with sort order desc.

c0ac0e8

ianliuwk1019 requested a review from craigyu November 14, 2024 20:26

ianliuwk1019 added 3 commits November 14, 2024 12:51

Fix the wrong file commit.

53a8426

Merge branch 'feat/backend-pagination-sort-search' into feat/1626-add…

87fe31c

…-tests-pagination-user_role_assignment-endpoint

Update swagger for desc sort order default.

19c431b

craigyu approved these changes Nov 15, 2024

View reviewed changes

ianliuwk1019 self-assigned this Nov 15, 2024

ianliuwk1019 merged commit 3c3ca61 into feat/backend-pagination-sort-search Nov 15, 2024
9 checks passed

ianliuwk1019 deleted the feat/1626-add-tests-pagination-user_role_assignment-endpoint branch November 15, 2024 18:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: #1626 Add tests pagination user role assignment endpoint #1646

feat: #1626 Add tests pagination user role assignment endpoint #1646

ianliuwk1019 commented Nov 4, 2024 •

edited

Loading

craigyu left a comment •

edited

Loading

sonarqubecloud bot commented Nov 14, 2024

feat: #1626 Add tests pagination user role assignment endpoint #1646

feat: #1626 Add tests pagination user role assignment endpoint #1646

Conversation

ianliuwk1019 commented Nov 4, 2024 • edited Loading

craigyu left a comment • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 14, 2024

Quality Gate passed for 'nr-forests-access-management_admin'

ianliuwk1019 commented Nov 4, 2024 •

edited

Loading

craigyu left a comment •

edited

Loading