Merge pull request #88 from bcgov/bug/start-view

Resolve initialization order issue
bcgov · Jun 5, 2024 · 7b06e47 · 7b06e47
2 parents 191508c + 04d376c
commit 7b06e47
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/frontend/src/views/StartView.vue b/frontend/src/views/StartView.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import { ref } from 'vue';
+import { onMounted, ref } from 'vue';
 import { useRouter } from 'vue-router';
 
 import { Breadcrumb, Button, Card, RadioButton } from '@/lib/primevue';
@@ -9,10 +9,7 @@ import type { Ref } from 'vue';
 
 // State
 const acceptDisclaimer: Ref<boolean> = ref(false);
-const crumbItems = ref([
-  { label: 'Home', url: getRoutePath(RouteNames.HOME) },
-  { label: 'PermitConnect Housing Navigator Service' }
-]);
+const crumbItems: Ref<Array<{ label: string; url?: string }>> = ref([]);
 const enquiryOrIntake: Ref<string | undefined> = ref(undefined);
 
 // Actions
@@ -28,6 +25,13 @@ const handleStartApplication = () => {
   if (enquiryOrIntake.value?.includes(RouteNames.INTAKE) || enquiryOrIntake.value?.includes(RouteNames.ENQUIRY))
     router.push({ name: enquiryOrIntake.value });
 };
+
+onMounted(() => {
+  crumbItems.value = [
+    { label: 'Home', url: getRoutePath(RouteNames.HOME) },
+    { label: 'PermitConnect Housing Navigator Service' }
+  ];
+});
 </script>
 
 <template>

diff --git a/frontend/src/views/SubmissionView.vue b/frontend/src/views/SubmissionView.vue
@@ -145,10 +145,7 @@ const filteredDocuments = computed(() => {
     </TabPanel>
     <TabPanel header="Files">
       <div class="mb-3 border-dashed file-upload border-round-md">
-        <FileUpload
-          :activity-id="props.activityId"
-          class=""
-        />
+        <FileUpload :activity-id="props.activityId" />
       </div>
       <div class="flex flex-row justify-content-between pb-3">
         <div class="flex align-items-center">