Allow multiple CHEFS forms to be configured/displayed #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FE can pull from multiple data sources. BE has dynamic basic auth based on the requested form ID
kyle1morel
requested review from
jujaga,
norrisng-bc,
TimCsaky,
jatindersingh93 and
wilwong89
as code owners
kyle1morel
changed the title
Coverage Report (Application)
|
wilwong89
approved these changes
Nov 29, 2023
jujaga
reviewed
Nov 29, 2023
Comment on lines
+17
to
+23
| "formId": "FORM_1_ID", | ||
| "formApiKey": "FORM_1_APIKEY" | ||
| }, | ||
| "form2": { | ||
| "name": "FORM_2_NAME", | ||
| "formId": "FORM_2_ID", | ||
| "formApiKey": "FORM_2_APIKEY" |
There was a problem hiding this comment.
Style: Since we know the values are nested, might be able to call it just "id" and "apiKey" without needing the form prefix for the attribute names.
app/src/controllers/chefs.ts
Outdated
| * BCeID/Business should only see their own submissions | ||
| */ | ||
| const filterData = (data: Array<ChefsSubmissionDataSource>) => { | ||
| const filterToUser = (req.currentUser?.tokenPayload as JwtPayload).identity_provider !== IdentityProvider.IDIR; |
There was a problem hiding this comment.
Just as a note - in the event we use a non-SSO Keycloak IAM we might not necessarily have the identity_provider attribute available. This is one of those few situations where I'm thinking it may be worth doing a defensive null check for tokenPayload?
app/src/types/ChefsFormConfig.ts
Outdated
Comment on lines
8
to
9
| formId: string; | ||
| formApiKey: string; |
There was a problem hiding this comment.
Could be 'id' and 'apiKey' from earlier style comment if we wanted to be more terse.
Coverage Report (Frontend)
|
jujaga
approved these changes
Nov 29, 2023
kyle1morel
force-pushed
the
feature/multi-form
branch
from
6e68153 to
bb94a84
Compare
jatindersingh93
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple CHEFS forms to be configured on the back end. Requests to the CHEFS API from the back end will create an Axios request with a dynamic basic auth by doing a lookup into the config map based on the form ID in the request. Submission data will be merged together for every form that is configured, before finally being filtered by user (if required) and sent to the front end.
Description
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments