-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Management - Front-end #108
Conversation
Code Climate has analyzed commit 0b84683 and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 9.5% (50% is the threshold). This pull request will bring the total coverage in the repository to 42.8% (-0.7% change). View more on Code Climate. |
Looks good for initial front-end work. Only comment is that the Revoke modal for Admins needs to say a different message than it does for Supervisors. ("The user will now lose all access...." message) |
d52c18d
to
1eeef95
Compare
done! |
1bdd22e
to
766e96f
Compare
c76f972
to
f334e2a
Compare
f334e2a
to
0b84683
Compare
comments addressed! |
@click=" | ||
selection = data; | ||
emit('userTable:manage', data); | ||
" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: use ()=>{ selection = data; emit('userTable:manage', data);}
Mainly just a consistency thing with other multi-statement handling elsewhere in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
Statistics function updates
0b84683
to
438d6dc
Compare
Add new config to determine deployed environment, and sso api connection
Fix helm secrets
438d6dc
to
1e0c4eb
Compare
Description
PADS-176
New view & modals added for user management
New permission added for granularity
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments