Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Management - Front-end #108

Merged
merged 10 commits into from
Jul 15, 2024
Merged

Conversation

sanjaytkbabu
Copy link
Contributor

@sanjaytkbabu sanjaytkbabu commented Jul 5, 2024

Description

PADS-176
New view & modals added for user management
New permission added for granularity

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Jul 5, 2024

Coverage Report (Application)

Totals Coverage
Statements: 45.39% ( 915 / 2016 )
Methods: 35.5% ( 131 / 369 )
Lines: 56.28% ( 596 / 1059 )
Branches: 31.97% ( 188 / 588 )

Copy link

github-actions bot commented Jul 5, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 31.56% ( 1430 / 4531 )
Methods: 27.27% ( 246 / 902 )
Lines: 36.29% ( 884 / 2436 )
Branches: 25.15% ( 300 / 1193 )

Copy link

codeclimate bot commented Jul 5, 2024

Code Climate has analyzed commit 0b84683 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 5

The test coverage on the diff in this pull request is 9.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.8% (-0.7% change).

View more on Code Climate.

@slhurley
Copy link
Collaborator

slhurley commented Jul 8, 2024

Looks good for initial front-end work. Only comment is that the Revoke modal for Admins needs to say a different message than it does for Supervisors. ("The user will now lose all access...." message)

@sanjaytkbabu sanjaytkbabu force-pushed the feature/user-mgmt-fe branch from d52c18d to 1eeef95 Compare July 9, 2024 14:47
@sanjaytkbabu
Copy link
Contributor Author

Looks good for initial front-end work. Only comment is that the Revoke modal for Admins needs to say a different message than it does for Supervisors. ("The user will now lose all access...." message)

done!

@sanjaytkbabu sanjaytkbabu force-pushed the feature/user-mgmt-fe branch 3 times, most recently from 1bdd22e to 766e96f Compare July 9, 2024 17:08
@sanjaytkbabu sanjaytkbabu marked this pull request as ready for review July 9, 2024 17:17
@sanjaytkbabu sanjaytkbabu force-pushed the feature/user-mgmt-fe branch 3 times, most recently from c76f972 to f334e2a Compare July 10, 2024 22:15
frontend/src/components/user/UserManageModal.vue Outdated Show resolved Hide resolved
frontend/src/views/user/UserManagementView.vue Outdated Show resolved Hide resolved
frontend/src/components/user/UserCreateModal.vue Outdated Show resolved Hide resolved
frontend/src/components/user/UserCreateModal.vue Outdated Show resolved Hide resolved
@sanjaytkbabu sanjaytkbabu force-pushed the feature/user-mgmt-fe branch from f334e2a to 0b84683 Compare July 11, 2024 22:37
@sanjaytkbabu
Copy link
Contributor Author

comments addressed!

@kyle1morel kyle1morel changed the base branch from master to release/user-management July 11, 2024 22:47
Comment on lines 86 to 91
@click="
selection = data;
emit('userTable:manage', data);
"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: use ()=>{ selection = data; emit('userTable:manage', data);}
Mainly just a consistency thing with other multi-statement handling elsewhere in the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@sanjaytkbabu sanjaytkbabu reopened this Jul 12, 2024
@sanjaytkbabu sanjaytkbabu force-pushed the feature/user-mgmt-fe branch from 438d6dc to 1e0c4eb Compare July 12, 2024 21:43
@wilwong89 wilwong89 merged commit 2e08cb6 into release/user-management Jul 15, 2024
16 of 17 checks passed
@wilwong89 wilwong89 deleted the feature/user-mgmt-fe branch July 15, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants