Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CHEFS Fields Added #113

Merged
merged 1 commit into from
Jul 15, 2024
Merged

More CHEFS Fields Added #113

merged 1 commit into from
Jul 15, 2024

Conversation

sanjaytkbabu
Copy link
Contributor

@sanjaytkbabu sanjaytkbabu commented Jul 12, 2024

Description

PADS-213
The following fields have been added to PCNS from CHEFS:
isCompanyRegistered (into the Y/N field)
rentalUnits (number of units for rental)
locality (address is pulled but not locality and province)
province
IndigenousHousingProviderName
nonProfitHousingSocietyName
housingCoopName

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codeclimate bot commented Jul 12, 2024

Code Climate has analyzed commit 3a9c1a6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 43.0% (0.0% change).

View more on Code Climate.

Copy link

github-actions bot commented Jul 12, 2024

Coverage Report (Application)

Totals Coverage
Statements: 45.45% ( 918 / 2020 )
Methods: 35.5% ( 131 / 369 )
Lines: 56.37% ( 597 / 1059 )
Branches: 32.09% ( 190 / 592 )

Copy link

github-actions bot commented Jul 12, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 32.55% ( 1421 / 4366 )
Methods: 28.16% ( 245 / 870 )
Lines: 37.14% ( 878 / 2364 )
Branches: 26.33% ( 298 / 1132 )

@sanjaytkbabu sanjaytkbabu force-pushed the feature/more-chefs-fields branch from ba1bc49 to 3a9c1a6 Compare July 12, 2024 23:04
@wilwong89 wilwong89 merged commit 14ce9cc into master Jul 15, 2024
18 of 19 checks passed
@wilwong89 wilwong89 deleted the feature/more-chefs-fields branch July 15, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants