Revamped SubmissionListNavigator #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qhanson55
requested review from
kyle1morel,
wilwong89 and
sanjaytkbabu
as code owners
Coverage Report (Application)
|
Coverage Report (Frontend)
|
|
Code Climate has analyzed commit c94a3bf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 43.1% (0.1% change). View more on Code Climate. |
|
Everything is looking good! Just one minor comment, First name heading is split into two rows, can we put it into one like the rest? Thanks! |
qhanson55
force-pushed
the
feature/revamp-submissions-view
branch
from
0431344 to
20a99d5
Compare
Fixed! Nice catch |
sanjaytkbabu
previously approved these changes
Jul 16, 2024
wilwong89
reviewed
Jul 17, 2024
qhanson55
force-pushed
the
feature/revamp-submissions-view
branch
from
20a99d5 to
db52c3f
Compare
|
I have combined PADS-207 & PADS-220 as the bug is related to this PR and is only replicated here. |
qhanson55
dismissed
sanjaytkbabu’s stale review
added another ticket/bigfix to PR
… to each column, based on PADS-189 comment
qhanson55
force-pushed
the
feature/revamp-submissions-view
branch
from
2cb62cb to
d487adb
Compare
wilwong89
reviewed
Jul 18, 2024
wilwong89
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revamped SubmissionListNavigator based on criteria in the comment (11:59am) in PADS-189.
Types of changes
Feature, added visibility and functionality to the tabes fields to greater help Navigators utilize the Submissions List.
Checklist
Further comments