Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility updates #158

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Accessibility updates #158

merged 1 commit into from
Sep 12, 2024

Conversation

kyle1morel
Copy link
Collaborator

Description

Adds aria-labelledby to form components
Resolves keyboard navigation highlighting issue

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Sep 10, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 27.18% ( 1556 / 5725 )
Methods: 23.29% ( 256 / 1099 )
Lines: 31.52% ( 967 / 3068 )
Branches: 21.37% ( 333 / 1558 )

Copy link

codeclimate bot commented Sep 10, 2024

Code Climate has analyzed commit 05ea57c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 36.6% (0.0% change).

View more on Code Climate.

Copy link

github-actions bot commented Sep 10, 2024

Coverage Report (Application)

Totals Coverage
Statements: 37.73% ( 944 / 2502 )
Methods: 26.98% ( 119 / 441 )
Lines: 49.02% ( 626 / 1277 )
Branches: 25.38% ( 199 / 784 )

@kyle1morel kyle1morel force-pushed the feature/accessibility branch from 461ff31 to 6d3ace4 Compare September 10, 2024 23:21
@kyle1morel kyle1morel force-pushed the feature/accessibility branch from 6d3ace4 to 05ea57c Compare September 12, 2024 16:53
@kyle1morel kyle1morel merged commit 85e1b89 into master Sep 12, 2024
18 of 19 checks passed
@kyle1morel kyle1morel deleted the feature/accessibility branch September 12, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants