Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beforeEnter guards to router #167

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

kyle1morel
Copy link
Collaborator

@kyle1morel kyle1morel commented Sep 18, 2024

Description

Updates the router to ensure consistent behaviour with refreshing in both local development and deployments.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Sep 18, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 26.76% ( 1557 / 5818 )
Methods: 21.51% ( 219 / 1018 )
Lines: 30.95% ( 899 / 2905 )
Branches: 23.17% ( 439 / 1895 )

Copy link

github-actions bot commented Sep 18, 2024

Coverage Report (Application)

Totals Coverage
Statements: 37.74% ( 940 / 2491 )
Methods: 26.98% ( 119 / 441 )
Lines: 48.98% ( 622 / 1270 )
Branches: 25.51% ( 199 / 780 )

@kyle1morel kyle1morel force-pushed the feature/app-bootstraping branch from 5ec4da8 to ce2202c Compare September 18, 2024 19:13
@kyle1morel kyle1morel marked this pull request as ready for review September 18, 2024 19:23
@kyle1morel kyle1morel changed the title Add global beforeEnter route callback Add beforeEnter guards to router Sep 18, 2024
@kyle1morel kyle1morel force-pushed the feature/app-bootstraping branch from ce2202c to 73e04ff Compare September 18, 2024 19:28
@kyle1morel kyle1morel force-pushed the feature/app-bootstraping branch from 73e04ff to 0827fc0 Compare September 18, 2024 19:36
@kyle1morel kyle1morel merged commit aaebfbe into release/interregnum Sep 18, 2024
16 of 17 checks passed
@kyle1morel kyle1morel deleted the feature/app-bootstraping branch September 18, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants