Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update statistics to not include drafts #168

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

kyle1morel
Copy link
Collaborator

Description

Update statistics function to not include submissions and enquiries in Draft status
Updates statistics table to clarify total count

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

);
}

export async function down(knex: Knex): Promise<void> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 6 locations. Consider refactoring.

/* eslint-disable max-len */
import type { Knex } from 'knex';

export async function up(knex: Knex): Promise<void> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function up has 129 lines of code (exceeds 25 allowed). Consider refactoring.

/* eslint-disable max-len */
import type { Knex } from 'knex';

export async function up(knex: Knex): Promise<void> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 6 locations. Consider refactoring.

);
}

export async function down(knex: Knex): Promise<void> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function down has 129 lines of code (exceeds 25 allowed). Consider refactoring.

@@ -0,0 +1,272 @@
/* eslint-disable max-len */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File 20240919000000_010-statistics-update.ts has 263 lines of code (exceeds 250 allowed). Consider refactoring.

Copy link

codeclimate bot commented Sep 19, 2024

Code Climate has analyzed commit b83f819 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 2

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 36.7% (0.0% change).

View more on Code Climate.

Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 27.29% ( 1562 / 5723 )
Methods: 23.38% ( 257 / 1099 )
Lines: 31.68% ( 975 / 3078 )
Branches: 21.35% ( 330 / 1546 )

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 37.73% ( 944 / 2502 )
Methods: 26.98% ( 119 / 441 )
Lines: 49.02% ( 626 / 1277 )
Branches: 25.38% ( 199 / 784 )

@kyle1morel kyle1morel merged commit 99a65e5 into master Sep 19, 2024
18 of 19 checks passed
@kyle1morel kyle1morel deleted the bug/statistics branch September 19, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants