-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update statistics to not include drafts #168
Conversation
); | ||
} | ||
|
||
export async function down(knex: Knex): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 6 locations. Consider refactoring.
/* eslint-disable max-len */ | ||
import type { Knex } from 'knex'; | ||
|
||
export async function up(knex: Knex): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function up
has 129 lines of code (exceeds 25 allowed). Consider refactoring.
/* eslint-disable max-len */ | ||
import type { Knex } from 'knex'; | ||
|
||
export async function up(knex: Knex): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 6 locations. Consider refactoring.
); | ||
} | ||
|
||
export async function down(knex: Knex): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function down
has 129 lines of code (exceeds 25 allowed). Consider refactoring.
@@ -0,0 +1,272 @@ | |||
/* eslint-disable max-len */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File 20240919000000_010-statistics-update.ts
has 263 lines of code (exceeds 250 allowed). Consider refactoring.
Code Climate has analyzed commit b83f819 and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 36.7% (0.0% change). View more on Code Climate. |
Description
Update statistics function to not include submissions and enquiries in Draft status
Updates statistics table to clarify total count
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments