Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue soft deleting submissions and enquiries #169

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

kyle1morel
Copy link
Collaborator

Description

Resolves an issue with the soft delete of submissions and enquiries.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codeclimate bot commented Sep 19, 2024

Code Climate has analyzed commit 89b3ee8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 36.7% (0.0% change).

View more on Code Climate.

Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 27.29% ( 1562 / 5723 )
Methods: 23.38% ( 257 / 1099 )
Lines: 31.68% ( 975 / 3078 )
Branches: 21.35% ( 330 / 1546 )

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 37.73% ( 944 / 2502 )
Methods: 26.98% ( 119 / 441 )
Lines: 49.02% ( 626 / 1277 )
Branches: 25.38% ( 199 / 784 )

@kyle1morel kyle1morel merged commit 257d2d7 into master Sep 19, 2024
18 of 19 checks passed
@kyle1morel kyle1morel deleted the bug/soft-delete branch September 19, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants