Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove draft saving on stepper navigation #172

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

kyle1morel
Copy link
Collaborator

@kyle1morel kyle1morel commented Sep 20, 2024

Description

It was causing a duplicate entry to be created. Also unnecessary with the auto saving feature in place.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Caused a duplicate entry to be created
Copy link

codeclimate bot commented Sep 20, 2024

Code Climate has analyzed commit 3b74aab and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 36.3% (-0.1% change).

View more on Code Climate.

Copy link

github-actions bot commented Sep 20, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 26.77% ( 1553 / 5801 )
Methods: 21.58% ( 219 / 1015 )
Lines: 30.87% ( 895 / 2899 )
Branches: 23.26% ( 439 / 1887 )

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 37.74% ( 940 / 2491 )
Methods: 26.98% ( 119 / 441 )
Lines: 48.98% ( 622 / 1270 )
Branches: 25.51% ( 199 / 780 )

@kyle1morel kyle1morel merged commit 994a23a into master Sep 23, 2024
18 of 19 checks passed
@kyle1morel kyle1morel deleted the bug/duplicate-draft branch September 23, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants