Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submitted applications page #200

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

wilwong89
Copy link
Contributor

Description

Updated submitted applications permit page with new card designs, wording consistencies, and utilizing new StatusPill component.
PADS-359

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Nov 23, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 25.08% ( 1640 / 6540 )
Methods: 20.18% ( 227 / 1125 )
Lines: 29.71% ( 956 / 3218 )
Branches: 20.8% ( 457 / 2197 )

Copy link

github-actions bot commented Nov 23, 2024

Coverage Report (Application)

Totals Coverage
Statements: 36.03% ( 1028 / 2853 )
Methods: 24.7% ( 123 / 498 )
Lines: 47.74% ( 697 / 1460 )
Branches: 23.24% ( 208 / 895 )

@slhurley
Copy link
Collaborator

Looking good....2 issues I see:

  • The Latest Updates note is not working and also it is showing some weird code instead of a note...if there is no note it should be empty and if there is one it should show.
  • Required Permits that show should no longer be hyperlinked (or appear to be a hyperlink)
  • Under Required Permits, it says "We are investigating...." when empty but what if there is nothing left to investigate? (Perhaps a UX question)

@wilwong89 wilwong89 force-pushed the feature/new-permitslist branch 3 times, most recently from ead745f to 61640ee Compare November 25, 2024 17:33
@wilwong89
Copy link
Contributor Author

Looking good....2 issues I see:

  • The Latest Updates note is not working and also it is showing some weird code instead of a note...if there is no note it should be empty and if there is one it should show.
  • Required Permits that show should no longer be hyperlinked (or appear to be a hyperlink)
  • Under Required Permits, it says "We are investigating...." when empty but what if there is nothing left to investigate? (Perhaps a UX question)
  • Note fixed. Some temporary placeholder slipped though.
  • Appearance of link removed
  • Will need UX to chime in on this one. Not sure how to proceed.

@naixin-zhangbc
Copy link

naixin-zhangbc commented Nov 25, 2024

Looking good! I'll confirm with Navigators on what to display when there's nothing to investigate and get back to you in a bit. Here are a few other issues:

  • When there's no updates, the Latest updates in the card should display "No updates at the moment"
  • The spacing between permit cards is missing. It should be 16 px for both the Required Permits section and the Submitted Applications section.
  • Please remove the hover effects from the permits in the Required Permits section, so that it doesn't look interactive.
  • Please change the "Ask a Navigator" button to "Ask my Navigator", and change the style to the secondary button style. Please let me know if you need the css.

Re: re-ordering the dropdown on Nav side.

  • For Application stage, please follow this order: Pre-submission, Application submission, Technical review, Pending decision, and Post-decision.
  • For Application status, please switch "Pending client action" and "In progress". The rest looks good to me!

@wilwong89
Copy link
Contributor Author

Looking good! I'll confirm with Navigators on what to display when there's nothing to investigate and get back to you in a bit. Here are a few other issues:

  • When there's no updates, the Latest updates in the card should display "No updates at the moment"
  • The spacing between permit cards is missing. It should be 16 px for both the Required Permits section and the Submitted Applications section.
  • Please remove the hover effects from the permits in the Required Permits section, so that it doesn't look interactive.
  • Please change the "Ask a Navigator" button to "Ask my Navigator", and change the style to the secondary button style. Please let me know if you need the css.

Re: re-ordering the dropdown on Nav side.

  • For Application stage, please follow this order: Pre-submission, Application submission, Technical review, Pending decision, and Post-decision.
  • For Application status, please switch "Pending client action" and "In progress". The rest looks good to me!

Changes made, now awaiting final designs of the "Required Permits" section.

@naixin-zhangbc
Copy link

naixin-zhangbc commented Nov 26, 2024

Re: the empty state messaging for the Require Permits section.

  • Replace the current message with "We will update the necessary permits here as the project progresses. You may see this message while we are investigating or if no application is needed at this time."
  • Show this message when NO permits are in "Pre-submission", OR when NONE of the "Pre-submission" permits' Needed field is "Yes".

Notes: This new solution displays a generic message that covers all scenarios. I experimented with showing different messages for each specific scenario, but doing so would require project-level states, which we don't have in place completely atm.

@wilwong89 wilwong89 force-pushed the feature/new-permitslist branch 2 times, most recently from 563df61 to fcc6653 Compare November 27, 2024 02:28
@wilwong89 wilwong89 changed the base branch from release/interregnum to master November 27, 2024 19:22
@wilwong89 wilwong89 force-pushed the feature/new-permitslist branch 2 times, most recently from 3d793fd to 5e54036 Compare November 28, 2024 17:29
@naixin-zhangbc
Copy link

naixin-zhangbc commented Nov 29, 2024

Please make this additional change. Change the empty state message for the Submitted Applications section from "You will see your permit applications here once submitted" to "We will update your submitted applications here as the project progresses".

This change will mitigate user confusion. Captured this problem while reviewing another ticket. The old message doesn't consider the situation when Props submit an intake form, they may have already submitted applications.

@kyle1morel
Copy link
Collaborator

Can be merged once sign off given by UX.

@wilwong89 wilwong89 force-pushed the feature/new-permitslist branch from 5e54036 to 5465a66 Compare December 2, 2024 21:26
Minor styling fixes
Reorder Permit Auth Status in dropdowns
Reorder Permit Status in dropdowns
Fix bug with permit note
@wilwong89 wilwong89 force-pushed the feature/new-permitslist branch from 5465a66 to 8db2599 Compare December 2, 2024 21:30
@naixin-zhangbc
Copy link

Can be merged once sign off given by UX.

Reviewed again. This is good to go. Thanks!

@kyle1morel kyle1morel merged commit d7b36d0 into master Dec 3, 2024
18 of 19 checks passed
@kyle1morel kyle1morel deleted the feature/new-permitslist branch December 3, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants