Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake form - advanced mapping component #205

Draft
wants to merge 1 commit into
base: release/mapping
Choose a base branch
from

Conversation

sanjaytkbabu
Copy link
Contributor

@sanjaytkbabu sanjaytkbabu commented Nov 28, 2024

Description

PADS-160
Advanced mapping features added to Map component
Migration added to add geo_json column to submission table
Model and types modified to include geoJSON
SubmissionIntakeForm updated with advanced map
externalApiService updated with api calls to obtain parcel IDs on polygon draw and nearest occupant on pin drop

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@sanjaytkbabu sanjaytkbabu force-pushed the feature/advanced-mapping branch 2 times, most recently from 4805de4 to 333364a Compare November 28, 2024 00:34
Copy link

github-actions bot commented Nov 28, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 24.85% ( 1647 / 6627 )
Methods: 20.07% ( 228 / 1136 )
Lines: 29.53% ( 962 / 3258 )
Branches: 20.47% ( 457 / 2233 )

@sanjaytkbabu sanjaytkbabu force-pushed the feature/advanced-mapping branch from 333364a to 74304c1 Compare November 28, 2024 01:31
Copy link

github-actions bot commented Nov 28, 2024

Coverage Report (Application)

Totals Coverage
Statements: 35.45% ( 1029 / 2903 )
Methods: 24.31% ( 123 / 506 )
Lines: 46.97% ( 698 / 1486 )
Branches: 22.83% ( 208 / 911 )

@sanjaytkbabu sanjaytkbabu force-pushed the feature/advanced-mapping branch 3 times, most recently from 1ed8fb6 to caedfcf Compare November 28, 2024 17:19
@sanjaytkbabu sanjaytkbabu reopened this Nov 28, 2024
@sanjaytkbabu sanjaytkbabu force-pushed the feature/advanced-mapping branch 9 times, most recently from 03c7503 to ec11705 Compare November 29, 2024 16:59
@Subin1Doo
Copy link

Pin drop - We shouldn't allow them to have multiple pin drops. We should allow them to move the location of the pin drop (example: drag and drop the pin to a new location OR just clicking elsewhere will dismiss the initial pin drop and appear at the new location).

We shouldn't allow them to pin drop and draw a polygon on the same map. It should be one or the other. Thank you!

@sanjaytkbabu sanjaytkbabu force-pushed the feature/advanced-mapping branch 3 times, most recently from d3c56da to 64a163e Compare December 8, 2024 01:53
… model & types updated, externalAPIService updated
@sanjaytkbabu sanjaytkbabu force-pushed the feature/advanced-mapping branch from 64a163e to b558659 Compare December 10, 2024 02:43
@sanjaytkbabu
Copy link
Contributor Author

Pin drop - We shouldn't allow them to have multiple pin drops. We should allow them to move the location of the pin drop (example: drag and drop the pin to a new location OR just clicking elsewhere will dismiss the initial pin drop and appear at the new location).

We shouldn't allow them to pin drop and draw a polygon on the same map. It should be one or the other. Thank you!

done!

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants