Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit Tracker View #206

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Permit Tracker View #206

merged 1 commit into from
Dec 3, 2024

Conversation

qhanson55
Copy link
Collaborator

@qhanson55 qhanson55 commented Nov 29, 2024

Description

Created tracker page to replace the old tracker modal.
Better flow and viewing in the application for proponents so they can see all relevant information towards the permit.
PADS-360

Types of changes

New feature (non-breaking change which adds functionality)
Documentation (non-breaking change with enhancements to documentation)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Nov 29, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 24.68% ( 1641 / 6650 )
Methods: 19.98% ( 227 / 1136 )
Lines: 29.28% ( 957 / 3269 )
Branches: 20.36% ( 457 / 2245 )

Copy link

github-actions bot commented Nov 29, 2024

Coverage Report (Application)

Totals Coverage
Statements: 36.25% ( 1047 / 2888 )
Methods: 24.6% ( 123 / 500 )
Lines: 47.55% ( 698 / 1468 )
Branches: 24.57% ( 226 / 920 )

@qhanson55 qhanson55 force-pushed the feature/permit-tracker-page branch from bb5ffd4 to 2df0356 Compare November 29, 2024 01:41
@naixin-zhangbc
Copy link

naixin-zhangbc commented Nov 29, 2024

The look and feel is great, but there are some major issues. I'm not sure if all of them are part of this ticket/branch though.

  • The empty status pill problem occurred on all permits that are added automatically from the intake form, including the permits from both the "permits you have submitted" and "permits you think you might need" sections.
  • I see the permit cards in the Submitted Applications section are using the old design. I guess it's because the new design is not part of this branch?

I'm not sure if the followings are issues, or they are not showing properly because they aren't part of this branch.

  • The submitted permits from the intake form shouldn't appear on Props' project page upon the intake submission. They should show after Navs finish their intake process. Maybe this issue is caused by the removal of the "needed" data from the rule for showing Submitted Applications? Might want to check with Wilson. This shows correctly on his branch. Upon intake form submission, this is what Props should see.
Screenshot 2024-11-29 at 10 48 59 AM **But this is how it shows in this branch** Screenshot 2024-11-29 at 10 51 36 AM
  • This "status not available" should not happen either. This might be related to the issue above?
Screenshot 2024-11-29 at 10 54 31 AM

Once these questions are cleared up, I'll continue the review.

@slhurley
Copy link
Collaborator

slhurley commented Dec 2, 2024

Agree we might need to merge Wilsons work together with this to evaluate properly but any problems with the first page are not part of this PR. The only thing I noticed missing is the little ? icon beside "Application status and progress" doesn't do anything?

@qhanson55 qhanson55 force-pushed the feature/permit-tracker-page branch 2 times, most recently from 9f40cc7 to a7cb33f Compare December 2, 2024 19:24
@qhanson55 qhanson55 force-pushed the feature/permit-tracker-page branch from a7cb33f to c9f3ae4 Compare December 2, 2024 23:01
@qhanson55 qhanson55 force-pushed the feature/permit-tracker-page branch 4 times, most recently from 7fac2d6 to ccd6eed Compare December 3, 2024 02:08
@qhanson55 qhanson55 force-pushed the feature/permit-tracker-page branch from ccd6eed to 9f51063 Compare December 3, 2024 02:11
@wilwong89 wilwong89 merged commit 2693cfb into master Dec 3, 2024
18 of 19 checks passed
@wilwong89 wilwong89 deleted the feature/permit-tracker-page branch December 3, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants