Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve draft create/reopening issues #207

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

kyle1morel
Copy link
Collaborator

@kyle1morel kyle1morel commented Nov 29, 2024

Description

Now using proper middleware when reopening a draft. Resolves 403 error being received previously.
Correctly reloading documents for drafts & submitted intakes.
Resolve issue with creating a draft via file upload.

https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-387

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Nov 29, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 25.02% ( 1638 / 6547 )
Methods: 20.18% ( 227 / 1125 )
Lines: 29.79% ( 956 / 3209 )
Branches: 20.56% ( 455 / 2213 )

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 36.03% ( 1028 / 2853 )
Methods: 24.7% ( 123 / 498 )
Lines: 47.74% ( 697 / 1460 )
Branches: 23.24% ( 208 / 895 )

@kyle1morel kyle1morel changed the title Resolve issue reopening drafts Resolve issues when reopening drafts Nov 29, 2024
@kyle1morel kyle1morel changed the title Resolve issues when reopening drafts Resolve draft create/reopening issues Nov 29, 2024
@kyle1morel kyle1morel merged commit 2d013f6 into master Dec 2, 2024
18 of 19 checks passed
@kyle1morel kyle1morel deleted the bug/draft-reload branch December 2, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants