Submission Intake Form - bugs in proponent entered applied permits #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qhanson55
requested review from
kyle1morel,
wilwong89 and
sanjaytkbabu
as code owners
Coverage Report (Frontend)
|
Coverage Report (Application)
|
kyle1morel
reviewed
Dec 4, 2024
Comment on lines
1
to
7
| import type { IStamps } from '@/interfaces'; | ||
|
|
||
| export type IntakeAppliedPermit = { | ||
| permitTypeId?: number; | ||
| statusLastVerified?: string; | ||
| trackingId?: string; | ||
| } & Partial<IStamps>; |
There was a problem hiding this comment.
Is this necessary over the existing Permit type, or a partial of? This is just a specific subset of that.
qhanson55
force-pushed
the
bug/intake-applied-permits
branch
from
1c0ed84 to
bcc9614
Compare
kyle1morel
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set max date to current date and fixed formatting issue.
Usability.
PADS-383
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments
Deleted some commented code that snuck in on a previous branch.