Update application footer #212
Conversation
kyle1morel
requested review from
wilwong89,
sanjaytkbabu and
qhanson55
as code owners
Coverage Report (Frontend)
|
Coverage Report (Application)
|
kyle1morel
force-pushed
the
feature/footer
branch
from
9898ab0 to
27e59aa
Compare
| @@ -158,7 +158,7 @@ function updateQueryParams() { | |||
| :sort-order="pagination.order" | |||
| paginator-template="RowsPerPageDropdown CurrentPageReport PrevPageLink NextPageLink " | |||
| current-page-report-template="{first}-{last} of {totalRecords}" | |||
| :rows-per-page-options="[10, 20, 50]" | |||
| :rows-per-page-options="[10, 20, 50, submissions?.length as number]" | |||
There was a problem hiding this comment.
Is this meant to behave as a "show all rows" option? The value on this looks like it can change, which could be jarring, or slightly strange if there happen to be exactly 10, 20 or 50 records present.
There was a problem hiding this comment.
Yes. Request from the business to have an "all" option. Made this dynamic and only appear when needed.
| border-top: 3px solid #fcba19; | ||
| border-bottom: 3px solid #fcba19; | ||
| background-color: #252423 !important; |
There was a problem hiding this comment.
Not sure if this is possible, but if we have CSS/SCSS variable constants defined for these colors, it would be good to reference those in our main sheet in lieu of defining them explicitly here.
There was a problem hiding this comment.
This should reference surface 900 or something once the PrimeVue 4 changes come in. I'll leave a TODO on this.
frontend/src/locales/en-CA.json
Outdated
| "contact1": "We can help in over 220 languages and through other accessible options.", | ||
| "contact2": "Call, email or text us", | ||
| "contact3": ", or", | ||
| "contact4": "find a service centre.", |
There was a problem hiding this comment.
The GCPE site did not have a period at the end of this sentence.
Aligning to new style guide
Extra padding. Add option for all rows in paginator
kyle1morel
force-pushed
the
feature/footer
branch
from
f2e7cf6 to
dd246c4
Compare
Description
Aligning to new style guide
https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-372?
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments