Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured and added keyboard navigation for public facing components #230

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

qhanson55
Copy link
Collaborator

Description

Ensured and added the ability to navigate the application (proponent side) with keyboard
So that we are WCAG 2.2 compliant for public facing components
PADS-310

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

The tests that would cover keyboard navigation are too in depth to implement for this ticket. Should be applied to future Integration level Testing.

Copy link

github-actions bot commented Dec 20, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 46.2% ( 3189 / 6902 )
Methods: 34.92% ( 404 / 1157 )
Lines: 53.87% ( 1845 / 3425 )
Branches: 40.52% ( 940 / 2320 )

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 35.86% ( 1064 / 2967 )
Methods: 25.2% ( 128 / 508 )
Lines: 47.5% ( 702 / 1478 )
Branches: 23.85% ( 234 / 981 )

@slhurley
Copy link
Collaborator

slhurley commented Dec 20, 2024

  1. First page of tracker - The project name and the icon beside it is skipped. It should come after the breadcrumbs. Also the tooltips are skipped.
  2. Permit details page - The "What does the status mean" is skipped.
  3. All pages - Tool tip can not be accessed with keyboard
  4. On the 2 intake forms, "Back to Housing" doesn't do anything if you are on it and press Enter.
  5. One the 2 intake forms, after the Submit button the keyboard focus should go to Assistance and then to the footer content
  6. The "On this page" links on main Prop Housing page - pressing Enter on one of them properly jumps to that section but the focus is off and should have gone to the ie. Submit an Enquiry or Submit a project button or for Drafts the first line and be able to select it.
  7. The Submit an Enquiry and Submit a Project buttons on Housing page require you to tab twice.

@qhanson55 qhanson55 force-pushed the chore/improve-keyboard-navigation branch 2 times, most recently from 36482f7 to 9c6600c Compare December 24, 2024 20:22
@naixin-zhangbc
Copy link

This hasn't been fixed. It still goes to the footer before the Assistance.

On the 2 intake forms, after the Submit button the keyboard focus should go to Assistance and then to the footer content.

Permit status pills' tooltips are skipped

All pages - Tool tip can not be accessed with keyboard

The keyboard focus should go to the first tab-able component in that section, not the header.

On this page links - if you use one of the links to jump to a section, keyboard focus should go to that section. Example: Jumps to general enquiries section, pressing the tab key will take keyboard focus to submit enquiry button.

This one is good, but I can't test it as a Proponent. So just want to make sure that the linked project name goes to the intake form on Proponent side, not on Nav side.

First page of tracker - The project name and the icon beside it is skipped. It should come after the breadcrumbs

@qhanson55 qhanson55 force-pushed the chore/improve-keyboard-navigation branch from 9c6600c to 6da3bf5 Compare December 24, 2024 20:43
@qhanson55 qhanson55 force-pushed the chore/improve-keyboard-navigation branch from 6da3bf5 to d2ea2d6 Compare December 31, 2024 19:05
@kyle1morel
Copy link
Collaborator

Tentatively approved pending UX sign off

@qhanson55 qhanson55 force-pushed the chore/improve-keyboard-navigation branch from d2ea2d6 to 508e923 Compare December 31, 2024 19:25
@naixin-zhangbc
Copy link

Reviewed. All good!

@kyle1morel kyle1morel merged commit 85a68a0 into master Dec 31, 2024
18 of 19 checks passed
@kyle1morel kyle1morel deleted the chore/improve-keyboard-navigation branch December 31, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants