Update dropdown values intake forms, DB migration to convert previous values to new values #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwong89
requested review from
kyle1morel,
sanjaytkbabu and
qhanson55
as code owners
Coverage Report (Frontend)
|
Coverage Report (Application)
|
|
I'm worried about using |
jujaga
reviewed
Dec 24, 2024
app/src/db/migrations/20241218000000_018-intake-value-conversion.ts
Outdated
Show resolved
Hide resolved
kyle1morel
reviewed
Dec 30, 2024
frontend/src/components/housing/submission/SubmissionIntakeForm.vue
Outdated
Show resolved
Hide resolved
kyle1morel
reviewed
Dec 30, 2024
wilwong89
force-pushed
the
feature/data-conversion
branch
from
503942a to
4a6a314
Compare
Created new migration Edited constants for front and backend Modified FE/BE validators Updated tests
… updated some localized text
wilwong89
force-pushed
the
feature/data-conversion
branch
2 times, most recently
from
1ef2056 to
c2e65b0
Compare
wilwong89
force-pushed
the
feature/data-conversion
branch
from
c2e65b0 to
a9e39d0
Compare
qhanson55
approved these changes
Jan 9, 2025
kyle1morel
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate several data values from old data to new data.
See tickets for details: PADS 403, PADS 412
Modify CHEFS imports to account for value changes
Update dropdown values in intakes forms to account for new values.
Update tests related to intake forms.
Types of changes
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments