Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with form incorrectly setting read-only state #232

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

kyle1morel
Copy link
Collaborator

@kyle1morel kyle1morel commented Dec 31, 2024

Description

Resolve issue with form incorrectly setting read-only state.

https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-418

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Dec 31, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 46.7% ( 3222 / 6900 )
Methods: 35.26% ( 408 / 1157 )
Lines: 54.43% ( 1863 / 3423 )
Branches: 40.99% ( 951 / 2320 )

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 35.86% ( 1064 / 2967 )
Methods: 25.2% ( 128 / 508 )
Lines: 47.5% ( 702 / 1478 )
Branches: 23.85% ( 234 / 981 )

@kyle1morel kyle1morel force-pushed the bug/intake-readonly branch 2 times, most recently from 7a74bbb to 6095ae5 Compare December 31, 2024 21:20
@wilwong89 wilwong89 merged commit 4ba83d3 into master Jan 3, 2025
19 checks passed
@wilwong89 wilwong89 deleted the bug/intake-readonly branch January 3, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants