Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API call to pull CHEFS intake form data #233

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

kyle1morel
Copy link
Collaborator

@kyle1morel kyle1morel commented Jan 6, 2025

Description

CHEFS form no longer in use and has been disabled. Data exists in DB backups. Call no longer necessary.

https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-179

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Form no longer in use. Data exists in DB backups. Call no longer necessary.
Copy link

github-actions bot commented Jan 6, 2025

Coverage Report (Application)

Totals Coverage
Statements: 37.06% ( 1061 / 2863 )
Methods: 26.28% ( 128 / 487 )
Lines: 48.44% ( 699 / 1443 )
Branches: 25.08% ( 234 / 933 )

Copy link

github-actions bot commented Jan 6, 2025

Coverage Report (Frontend)

Totals Coverage
Statements: 46.47% ( 3208 / 6903 )
Methods: 35.26% ( 408 / 1157 )
Lines: 54.09% ( 1852 / 3424 )
Branches: 40.83% ( 948 / 2322 )

@qhanson55 qhanson55 merged commit 7cb830f into master Jan 7, 2025
19 checks passed
@qhanson55 qhanson55 deleted the chore/remove-chefs-import branch January 7, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants