Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding functionality for notes to be added in a log #28

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

wilwong89
Copy link
Contributor

Description

Capability to add log notes and information that records services and informations for a submission.
Backend schema, type, and API changes required for adding a new DB table.
Frontend UI, component, type, and queries related to new DB table.

Types of changes

New feature (non-breaking change which adds functionality)

Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codeclimate bot commented Feb 14, 2024

Code Climate has analyzed commit 4ccea8d and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 3
Bug Risk 1

View more on Code Climate.

app/src/controllers/note.ts Show resolved Hide resolved
app/src/routes/v1/note.ts Show resolved Hide resolved
app/src/routes/v1/note.ts Outdated Show resolved Hide resolved
app/src/services/note.ts Show resolved Hide resolved
app/src/services/note.ts Outdated Show resolved Hide resolved
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 37.52% ( 221 / 589 )
Methods: 34.78% ( 40 / 115 )
Lines: 43.43% ( 142 / 327 )
Branches: 26.53% ( 39 / 147 )

app/src/routes/v1/note.ts Show resolved Hide resolved
app/src/db/migrations/20231212000000_init.ts Outdated Show resolved Hide resolved
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 42.59% ( 69 / 162 )
Methods: 21.74% ( 5 / 23 )
Lines: 61.54% ( 56 / 91 )
Branches: 16.67% ( 8 / 48 )

@wilwong89 wilwong89 force-pushed the feat/log-notes branch 4 times, most recently from dc753e3 to c0a2df4 Compare February 14, 2024 22:14
@wilwong89 wilwong89 marked this pull request as ready for review February 14, 2024 22:21
app/src/types/Note.ts Outdated Show resolved Hide resolved
@kyle1morel
Copy link
Collaborator

UI looks good. The notes upon save are not respecting new lines though.

@wilwong89 wilwong89 force-pushed the feat/log-notes branch 3 times, most recently from 13fe1c7 to 831b8b0 Compare February 15, 2024 18:44
frontend/src/components/note/NoteCard.vue Outdated Show resolved Hide resolved
frontend/src/components/note/NoteCard.vue Outdated Show resolved Hide resolved
frontend/src/components/note/NoteCard.vue Show resolved Hide resolved
@kyle1morel kyle1morel merged commit f1bbd58 into master Feb 15, 2024
18 of 20 checks passed
@kyle1morel kyle1morel deleted the feat/log-notes branch February 15, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants