-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding functionality for notes to be added in a log #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit 4ccea8d and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
wilwong89
force-pushed
the
feat/log-notes
branch
from
February 14, 2024 19:10
2faae74
to
4ebb4b4
Compare
wilwong89
force-pushed
the
feat/log-notes
branch
4 times, most recently
from
February 14, 2024 22:14
dc753e3
to
c0a2df4
Compare
wilwong89
requested review from
jujaga,
norrisng-bc,
TimCsaky,
jatindersingh93 and
kyle1morel
as code owners
February 14, 2024 22:21
wilwong89
force-pushed
the
feat/log-notes
branch
from
February 14, 2024 22:31
c0a2df4
to
17f1fca
Compare
kyle1morel
reviewed
Feb 14, 2024
kyle1morel
reviewed
Feb 14, 2024
kyle1morel
reviewed
Feb 14, 2024
kyle1morel
reviewed
Feb 14, 2024
kyle1morel
reviewed
Feb 14, 2024
kyle1morel
reviewed
Feb 14, 2024
kyle1morel
reviewed
Feb 14, 2024
kyle1morel
reviewed
Feb 14, 2024
kyle1morel
reviewed
Feb 14, 2024
kyle1morel
reviewed
Feb 14, 2024
kyle1morel
reviewed
Feb 14, 2024
UI looks good. The notes upon save are not respecting new lines though. |
wilwong89
force-pushed
the
feat/log-notes
branch
3 times, most recently
from
February 15, 2024 18:44
13fe1c7
to
831b8b0
Compare
kyle1morel
approved these changes
Feb 15, 2024
jujaga
reviewed
Feb 15, 2024
wilwong89
force-pushed
the
feat/log-notes
branch
from
February 15, 2024 20:07
831b8b0
to
030533b
Compare
wilwong89
force-pushed
the
feat/log-notes
branch
from
February 15, 2024 21:21
030533b
to
4ccea8d
Compare
jujaga
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Capability to add log notes and information that records services and informations for a submission.
Backend schema, type, and API changes required for adding a new DB table.
Frontend UI, component, type, and queries related to new DB table.
Types of changes
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments