feat: adding JOI validiation to backend #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Frontend)
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 5683bae and detected 17 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Coverage Report (Application)
|
wilwong89
force-pushed
the
feat/joi-validation
branch
from
9d07a5c to
d628fe0
Compare
wilwong89
force-pushed
the
feat/joi-validation
branch
from
d628fe0 to
662d237
Compare
wilwong89
requested review from
jujaga,
norrisng-bc,
TimCsaky,
jatindersingh93 and
kyle1morel
as code owners
kyle1morel
reviewed
Feb 27, 2024
app/src/middleware/validation.ts
Outdated
| // @ts-expect-error api-problem lacks a defined interface; code still works fine | ||
| import Problem from 'api-problem'; | ||
| import type { NextFunction, Request, Response } from '../interfaces/IExpress'; | ||
| // import type { NextFunction, Request, Response } from 'express'; |
kyle1morel
reviewed
Feb 27, 2024
app/src/middleware/validation.ts
Outdated
| return result ? [prop, result?.details] : undefined; | ||
| }) | ||
| .filter((error) => !!error) | ||
| .map((x) => x as any[]); |
There was a problem hiding this comment.
any[] should be a properly defined type.
kyle1morel
reviewed
Feb 27, 2024
| identityId: Joi.array().items(uuidv4), | ||
| idp: Joi.array().items(Joi.string().max(255)), | ||
| username: Joi.string().max(255), | ||
| email: Joi.string().max(255), |
There was a problem hiding this comment.
Should use an email regex validator. Ref COMS
kyle1morel
reviewed
Feb 27, 2024
Comment on lines
+81
to
88
| // Remove extra fields in permit that belongs to permitType | ||
| delete data.agency; | ||
| delete data.businessDomain; | ||
| delete data.sourceSystem; | ||
|
|
||
| // Convert form back to a proper Permit type | ||
| emit('permit:submit', { | ||
| const permitData = { | ||
| ...data, |
There was a problem hiding this comment.
Can we use an Omit here instead of deletes?
kyle1morel
reviewed
Feb 27, 2024
Comment on lines
+136
to
+139
| delete submissionData.submissionTypes; | ||
| delete submissionData.user; | ||
|
|
||
| emit('submit', submissionData); |
There was a problem hiding this comment.
Can we use an Omit here instead of deletes?
kyle1morel
reviewed
Feb 27, 2024
| @@ -28,7 +28,7 @@ const visible = defineModel<boolean>('visible'); | |||
|
|
|||
| // Default form values | |||
| let initialFormValues: any = { | |||
| createdAt: formatDateShort(new Date().toISOString()), | |||
| createdAt: new Date(), //formatDateShort(new Date().toISOString()), | |||
jujaga
reviewed
Feb 27, 2024
Installed JOI validation package Added validation for the following endpoints: document - createDocument, deleteDocument, listDocuments note - createNote, listNotes permit - createPermit, deletePermit, listPermits, updatePermit, submission - getStatistics, getSubmission, editSubmission user - searchUser Validator files under src/validators Middleware under src/middeleware/validation.ts Modified frontend NoteCard, NoteModal, PermitModal to submit ISO dates for notes entries Modified frontend SubmissionForm onSubmit JSON to match valid format
wilwong89
force-pushed
the
feat/joi-validation
branch
from
662d237 to
5683bae
Compare
jujaga
approved these changes
Feb 28, 2024
kyle1morel
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Installed JOI validation package
Added validation for the following endpoints:
document - createDocument, deleteDocument, listDocuments
note - createNote, listNotes
permit - createPermit, deletePermit, listPermits, updatePermit,
submission - getStatistics, getSubmission, editSubmission
user - searchUser
Validator files under src/validators
Middleware under src/middeleware/validation.ts
Modified frontend NoteCard, NoteModal, PermitModal to submit ISO dates for notes entries and remove extra fields
Modified frontend SubmissionForm to remove extra fields
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments