Road Map and Email set-up #44
Conversation
TimCsaky
force-pushed
the
email
branch
2 times, most recently
from
b88ad6b to
9770d9d
Compare
UpdateRoadmap component that could include the email form Road Map backend route, controller, service set up Backend Email service (using CHES) CHES connection environment variables
Coverage Report (Frontend)
|
Coverage Report (Application)
|
TimCsaky
requested review from
jujaga,
norrisng-bc,
jatindersingh93,
kyle1morel and
wilwong89
as code owners
Add BCC config for prod. Emails are sending.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| * @param {string} value The CSV string to parse | ||
| * @returns {string[]} An array of string values, or `value` if it is not a string | ||
| */ | ||
| export function parseCSV(value: string): Array<string> { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| router.use(requireSomeAuth); | ||
|
|
||
| // Send an email with the roadmap data | ||
| router.put('/', roadmapValidator.send, (req: Request, res: Response, next: NextFunction): void => { |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| if (emailData.to && !Array.isArray(emailData.to)) { | ||
| emailData.to = parseCSV(emailData.to); | ||
| } | ||
| if (emailData.cc && !Array.isArray(emailData.cc)) { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| * @returns {Promise} An axios response | ||
| */ | ||
| send(activityId: string, emailData: any) { | ||
| if (emailData.to && !Array.isArray(emailData.to)) { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| if (emailData.cc && !Array.isArray(emailData.cc)) { | ||
| emailData.cc = parseCSV(emailData.cc); | ||
| } | ||
| if (emailData.bcc && !Array.isArray(emailData.bcc)) { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
|
Code Climate has analyzed commit 336cbc9 and detected 7 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 9.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 34.8%. View more on Code Climate. |
Description
Types of changes
Checklist
Further comments