Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve early pilot release issues #45

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

kyle1morel
Copy link
Collaborator

@kyle1morel kyle1morel commented Mar 21, 2024

Description

This PR resolves the early found pilot release issues.

4a9b281 Resolve various permit modal issues
21ed493 Document mime type not a required field
19b1121 Resolve missing assigned user name in submissions list
1f85330 Remove jujaga from codeowners file

SHOWCASE-3614 SHOWCASE-3615 SHOWCASE-3616

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Mar 21, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 21.89% ( 371 / 1695 )
Methods: 24.92% ( 76 / 305 )
Lines: 24.22% ( 232 / 958 )
Branches: 14.58% ( 63 / 432 )

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 45.51% ( 405 / 890 )
Methods: 35.91% ( 65 / 181 )
Lines: 61.1% ( 289 / 473 )
Branches: 21.61% ( 51 / 236 )

@kyle1morel kyle1morel marked this pull request as ready for review March 21, 2024 23:19
Copy link

codeclimate bot commented Mar 21, 2024

Code Climate has analyzed commit c193847 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 13.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 36.4% (0.0% change).

View more on Code Climate.

Populate updated by, update form and back end validators
@kyle1morel kyle1morel force-pushed the bugfix/post-pilot-release-issues branch from 56dce07 to c193847 Compare March 22, 2024 20:49
@kyle1morel kyle1morel merged commit 8fc89ba into master Mar 22, 2024
20 of 22 checks passed
@kyle1morel kyle1morel deleted the bugfix/post-pilot-release-issues branch March 22, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants