-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include additional fields for submission table, UI updates #54
Conversation
Code Climate has analyzed commit b2f4abe and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 36.7% (0.9% change). View more on Code Climate. |
app/src/controllers/submission.ts
Outdated
queuePriority: parseInt(data.queuePriority), | ||
singleFamilyUnits: maxUnits, | ||
isRentalUnit: camelCaseToTitleCase(deDupeUnsure(data.isRentalUnit)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Unsure' is a pointless value.
maybe the CHEFS data should be converted true|false|null
in the database. The postgres boolean
type .. and prisma and joi.. support that.. (eg for knex table.boolean('isRentalUnit')
The isTruthy utils function might handle the deduping as well.
*/ | ||
export function camelCaseToTitleCase(input: string | null): string | null { | ||
if (!input) return input; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be get rid of extra line
f7bcf1b
to
b2f4abe
Compare
Description
Add the following fields to the submission table:
contactPreference
,contactApplicantRelationship
,projectDescription
,isRentalUnit
.Functionality for updating those fields.
Updated labels for certain submission types.
SHOWCASE-3600
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments