Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue sending emails with attachments #58

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

kyle1morel
Copy link
Collaborator

@kyle1morel kyle1morel commented Apr 5, 2024

Description

  • Checking for array length as well as truthiness.
  • Only replay auth header, not the entire thing

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codeclimate bot commented Apr 5, 2024

Code Climate has analyzed commit f7c9375 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 33.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 35.8% (0.0% change).

View more on Code Climate.

Copy link

github-actions bot commented Apr 5, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 21.11% ( 408 / 1933 )
Methods: 22.64% ( 79 / 349 )
Lines: 23.15% ( 250 / 1080 )
Branches: 15.67% ( 79 / 504 )

Copy link

github-actions bot commented Apr 5, 2024

Coverage Report (Application)

Totals Coverage
Statements: 46.75% ( 467 / 999 )
Methods: 36.82% ( 74 / 201 )
Lines: 61.22% ( 330 / 539 )
Branches: 24.32% ( 63 / 259 )

@kyle1morel kyle1morel changed the title Checking for array length Resolve issue sending emails with attachments Apr 5, 2024
@kyle1morel kyle1morel merged commit 980f47e into master Apr 5, 2024
21 of 22 checks passed
@kyle1morel kyle1morel deleted the bugfix/roadmap-attachments branch April 5, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant