Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow navigators to create empty submissions #64

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

wilwong89
Copy link
Contributor

Description

Allow navigators to create an empty submission that they can edit for their use.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Apr 13, 2024

Coverage Report (Application)

Totals Coverage
Statements: 48.87% ( 539 / 1103 )
Methods: 38.81% ( 85 / 219 )
Lines: 62.63% ( 362 / 578 )
Branches: 30.07% ( 92 / 306 )

Copy link

github-actions bot commented Apr 13, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 22.84% ( 483 / 2115 )
Methods: 21.71% ( 84 / 387 )
Lines: 26.19% ( 307 / 1172 )
Branches: 16.55% ( 92 / 556 )

Copy link

codeclimate bot commented Apr 13, 2024

Code Climate has analyzed commit 6760fb8 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 33.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 38.2% (0.0% change).

View more on Code Climate.

app/src/controllers/submission.ts Show resolved Hide resolved
app/src/controllers/submission.ts Outdated Show resolved Hide resolved
app/src/routes/v1/submission.ts Outdated Show resolved Hide resolved
app/src/services/submission.ts Outdated Show resolved Hide resolved
frontend/src/components/submission/SubmissionList.vue Outdated Show resolved Hide resolved
frontend/src/components/submission/SubmissionList.vue Outdated Show resolved Hide resolved
frontend/src/components/submission/SubmissionList.vue Outdated Show resolved Hide resolved
@wilwong89 wilwong89 force-pushed the feature/submission-create branch 2 times, most recently from 07c20dd to 6760fb8 Compare April 18, 2024 23:04
@kyle1morel kyle1morel force-pushed the feature/submission-create branch from 6760fb8 to 828fc28 Compare April 19, 2024 16:49
@kyle1morel kyle1morel merged commit 13d7411 into master Apr 19, 2024
14 of 15 checks passed
@kyle1morel kyle1morel deleted the feature/submission-create branch April 19, 2024 16:50
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants