SubmissionView to store + minor general refactors #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All components now reference a single submissionStore. Number of emits seriously cut down
Coverage Report (Application)
|
Coverage Report (Frontend)
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 15465bb and detected 7 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 13.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 37.9% (0.2% change). View more on Code Climate. |
kyle1morel
force-pushed
the
refactor/store
branch
2 times, most recently
from
09cba9e to
a37343e
Compare
wilwong89
reviewed
Apr 22, 2024
kyle1morel
force-pushed
the
refactor/store
branch
from
a37343e to
dfc2042
Compare
wilwong89
reviewed
Apr 23, 2024
kyle1morel
force-pushed
the
refactor/store
branch
3 times, most recently
from
47766e9 to
7c05f98
Compare
Minor other tweaks - SubmissionForm always editable
kyle1morel
force-pushed
the
refactor/store
branch
from
7c05f98 to
15465bb
Compare
wilwong89
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the state data from the SubmissionView into a new submissionStore. All components now read and write to this store. Numerous emits have been removed as the up/down prop passing is no longer required.
PR also includes some general refactoring, and couple minor bug fixes.
a37343e Refactor NoteModal to correctly use default props
0d4658a Refactor SubmissionView + child components to use a store
Types of changes
Checklist
Further comments