Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed character limit for activity information & AST notes #69

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

sanjaytkbabu
Copy link
Contributor

@sanjaytkbabu sanjaytkbabu commented Apr 23, 2024

Description

Removed character limit for activity information in submission schema

https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-73

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codeclimate bot commented Apr 23, 2024

Code Climate has analyzed commit da461fb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 37.9% (0.0% change).

View more on Code Climate.

Copy link

github-actions bot commented Apr 23, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 23.42% ( 510 / 2178 )
Methods: 21.43% ( 87 / 406 )
Lines: 26.68% ( 321 / 1203 )
Branches: 17.93% ( 102 / 569 )

Copy link

github-actions bot commented Apr 23, 2024

Coverage Report (Application)

Totals Coverage
Statements: 47.66% ( 539 / 1131 )
Methods: 37.44% ( 85 / 227 )
Lines: 60.74% ( 362 / 596 )
Branches: 29.87% ( 92 / 308 )

@sanjaytkbabu sanjaytkbabu requested a review from kyle1morel April 23, 2024 22:35
@sanjaytkbabu sanjaytkbabu changed the title Removed character limit for activity information [BUGFIX][PADS-73] - Removed character limit for activity information & AST notes Apr 23, 2024
@sanjaytkbabu sanjaytkbabu force-pushed the bugfix/PADS-73-act-info-limit branch 2 times, most recently from ec49a44 to d5d601d Compare April 24, 2024 16:00
@sanjaytkbabu sanjaytkbabu force-pushed the bugfix/PADS-73-act-info-limit branch from d5d601d to da461fb Compare April 24, 2024 16:10
@kyle1morel kyle1morel merged commit b3edbd5 into master Apr 24, 2024
21 of 22 checks passed
@kyle1morel kyle1morel deleted the bugfix/PADS-73-act-info-limit branch April 24, 2024 16:38
@kyle1morel kyle1morel changed the title [BUGFIX][PADS-73] - Removed character limit for activity information & AST notes Removed character limit for activity information & AST notes Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants