Allow multiple files to be selected/dropped at once #78
Conversation
Removed col class from form components
Migration included: data type changes, many new columns
Coverage Report (Application)
|
kyle1morel
force-pushed
the
feature/multi-upload
branch
from
896bf56 to
3696284
Compare
Coverage Report (Frontend)
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| ); | ||
| } | ||
|
|
||
| export async function down(knex: Knex): Promise<void> { |
There was a problem hiding this comment.
Function down has 80 lines of code (exceeds 25 allowed). Consider refactoring.
| submissionQuery = await submissionService.getSubmission(testSubmissionId.substring(0, 8).toUpperCase()); | ||
| } while (submissionQuery); | ||
|
|
||
| createSubmission: async (req: Request, res: Response, next: NextFunction) => { |
There was a problem hiding this comment.
Function createSubmission has 96 lines of code (exceeds 25 allowed). Consider refactoring.
| @@ -0,0 +1,195 @@ | |||
| import type { Knex } from 'knex'; | |||
|
|
|||
| export async function up(knex: Knex): Promise<void> { | |||
There was a problem hiding this comment.
Function up has 94 lines of code (exceeds 25 allowed). Consider refactoring.
| * @param {string} activityId Unique activity ID | ||
| * @returns {Promise<Activity | null>} The result of running the findFirst operation | ||
| */ | ||
| getActivity: async (activityId: string) => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| submissionQuery = await submissionService.getSubmission(testSubmissionId.substring(0, 8).toUpperCase()); | ||
| } while (submissionQuery); | ||
|
|
||
| createSubmission: async (req: Request, res: Response, next: NextFunction) => { |
There was a problem hiding this comment.
Function createSubmission has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 3696284 and detected 10 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 27.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 35.9% (-1.8% change). View more on Code Climate. |
Description
Allow multiple files to be selected/dropped at once
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments