Add BC OrgBook and BC Geocoder Lookups to SHAS Intake Form #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
| @@ -189,6 +254,7 @@ onBeforeMount(async () => { | |||
| </script> | |||
|
|
|||
| <template> | |||
| <div>{{ formRef?.values }}</div> | |||
There was a problem hiding this comment.
consider getting rid of this if dev is complete
|
Getting the following error when searching for an address: |
| @@ -23,7 +23,7 @@ router.get( | |||
| ); | |||
|
|
|||
| // Submission create draft endpoint | |||
| router.put('/draft', submissionValidator.createDraft, (req: Request, res: Response, next: NextFunction): void => { | |||
There was a problem hiding this comment.
Wondering if the validator isn't needed anymore?
There was a problem hiding this comment.
I think this got accidentally added in one of the many merges for the release/housing-intake form. I recall this validator wasn't meant for this route.
wilwong89
force-pushed
the
feature/orgbook-address-lookup
branch
from
26f0d40 to
144952b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusted intake form to search OrgBook and Geocoder APIs for BC registered businesses and addresses.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments