Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files tab - improve view and findability #86

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

sanjaytkbabu
Copy link
Contributor

@sanjaytkbabu sanjaytkbabu commented May 31, 2024

Description

PADS-24: Files tab - improve view and findability
Describe your changes in detail:
Added list view to the files tab
New upload button added
Added button to switch between grid and list views
Added search and sort functionality for files in both views
Changed list documents api to fetch created_by information
Changed created documents api to save information of user to the db
Modularized delete document view and functions

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented May 31, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 22.51% ( 533 / 2368 )
Methods: 20.13% ( 90 / 447 )
Lines: 25.52% ( 329 / 1289 )
Branches: 18.04% ( 114 / 632 )

app/src/controllers/document.ts Dismissed Show dismissed Hide dismissed
@sanjaytkbabu sanjaytkbabu force-pushed the feature/files-redesign branch 11 times, most recently from 3780674 to 5066038 Compare June 3, 2024 14:29
frontend/src/views/SubmissionView.vue Outdated Show resolved Hide resolved
frontend/src/views/SubmissionView.vue Outdated Show resolved Hide resolved
frontend/src/views/SubmissionView.vue Outdated Show resolved Hide resolved
app/src/controllers/document.ts Outdated Show resolved Hide resolved
app/src/services/document.ts Outdated Show resolved Hide resolved
app/src/services/document.ts Outdated Show resolved Hide resolved
app/src/services/document.ts Outdated Show resolved Hide resolved
app/src/services/document.ts Outdated Show resolved Hide resolved
app/src/db/models/document.ts Outdated Show resolved Hide resolved
frontend/src/views/SubmissionView.vue Outdated Show resolved Hide resolved
frontend/src/views/SubmissionView.vue Outdated Show resolved Hide resolved
frontend/src/views/SubmissionView.vue Outdated Show resolved Hide resolved
frontend/src/views/SubmissionView.vue Outdated Show resolved Hide resolved
@Subin1Doo
Copy link

Looking great!!
Some minor adjustments please :)

  • Center align the delete icon with the word "Action."

  • List / grid view icon - make them bigger

  • Hover over list/ grid icon-> I think we should add another visual cue here.. light blue circle/ square behind the icon? (I'll add this to Figma)

  • The length/ size of the sorting bar changes when you switch views, grid view sort bar is longer

  • Grid view sort bar should be the same length as list view sort bar

  • Grid view sort bar, can we make it like the way it is on Figma? All "sort by" columns pushed to the left so they are all closer to each other (List view sort bar looks good)

  • Grid view - for each file, bottom padding looks greater than top padding (the area around file name, info, and delete icon), can we close the white space by a tiny bit so it's equal to the top

  • Delete confirmation pop-up -> confirm button -> change to red

Thank you!

@sanjaytkbabu sanjaytkbabu force-pushed the feature/files-redesign branch 5 times, most recently from 3c9259c to fb41e41 Compare June 4, 2024 23:47
Copy link

github-actions bot commented Jun 4, 2024

Coverage Report (Application)

Totals Coverage
Statements: 47.09% ( 542 / 1151 )
Methods: 37.44% ( 85 / 227 )
Lines: 60.03% ( 365 / 608 )
Branches: 29.11% ( 92 / 316 )

Copy link

codeclimate bot commented Jun 4, 2024

Code Climate has analyzed commit c5d9306 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 4.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 36.5% (-1.0% change).

View more on Code Climate.

@sanjaytkbabu sanjaytkbabu force-pushed the feature/files-redesign branch from fb41e41 to 739abcb Compare June 5, 2024 00:24
@sanjaytkbabu sanjaytkbabu force-pushed the feature/files-redesign branch from 739abcb to c5d9306 Compare June 5, 2024 01:15
@kyle1morel kyle1morel merged commit 191508c into master Jun 5, 2024
18 of 22 checks passed
@kyle1morel kyle1morel deleted the feature/files-redesign branch June 5, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants