Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send email confirmation when SHAS/Enquiry confirmation page is displayed #92

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

sanjaytkbabu
Copy link
Contributor

@sanjaytkbabu sanjaytkbabu commented Jun 10, 2024

Description

Sends an email confirmation when SHAS confirmation page is displayed

https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-164

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 42.81% ( 709 / 1656 )
Methods: 33.33% ( 106 / 318 )
Lines: 55.08% ( 477 / 866 )
Branches: 26.69% ( 126 / 472 )

Copy link

github-actions bot commented Jun 10, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 29.99% ( 1084 / 3614 )
Methods: 26.77% ( 197 / 736 )
Lines: 33.44% ( 656 / 1962 )
Branches: 25.22% ( 231 / 916 )

@sanjaytkbabu sanjaytkbabu marked this pull request as ready for review June 11, 2024 14:36
@slhurley
Copy link
Collaborator

My mistake that we also need this on the Enquiry form. Also, first part of the message should say "The confirmation ID for your submission is: XXXX" followed by the second sentence you already have. Thanks!

@sanjaytkbabu sanjaytkbabu force-pushed the feat/intake-confirm-email branch from 3daefc8 to 6645c2f Compare June 11, 2024 15:46
@sanjaytkbabu
Copy link
Contributor Author

My mistake that we also need this on the Enquiry form. Also, first part of the message should say "The confirmation ID for your submission is: XXXX" followed by the second sentence you already have. Thanks!

done!

@sanjaytkbabu sanjaytkbabu force-pushed the feat/intake-confirm-email branch from 6645c2f to 53b0da2 Compare June 11, 2024 16:47
@sanjaytkbabu sanjaytkbabu changed the title Send email confirmation when SHAS confirmation page is displayed Send email confirmation when SHAS/Enquiry confirmation page is displayed Jun 11, 2024
@Subin1Doo
Copy link

Confirmation email message has been approved by the Navigators! No changes needed.

@sanjaytkbabu sanjaytkbabu force-pushed the feat/intake-confirm-email branch from 53b0da2 to f86ce8a Compare June 11, 2024 20:55
@sanjaytkbabu sanjaytkbabu reopened this Jun 11, 2024
@sanjaytkbabu sanjaytkbabu reopened this Jun 11, 2024
@sanjaytkbabu sanjaytkbabu reopened this Jun 11, 2024
@sanjaytkbabu sanjaytkbabu reopened this Jun 11, 2024
@sanjaytkbabu sanjaytkbabu force-pushed the feat/intake-confirm-email branch from f86ce8a to c39f091 Compare June 12, 2024 17:40
@sanjaytkbabu sanjaytkbabu force-pushed the feat/intake-confirm-email branch from c39f091 to da90af7 Compare June 12, 2024 18:17
@sanjaytkbabu sanjaytkbabu force-pushed the feat/intake-confirm-email branch from da90af7 to 58a5841 Compare June 12, 2024 18:24
@kyle1morel kyle1morel merged commit cc94c32 into release/housing-intake Jun 12, 2024
16 of 17 checks passed
@kyle1morel kyle1morel deleted the feat/intake-confirm-email branch June 12, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants