Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: differences in gw and pollen #1585

Merged
merged 18 commits into from
Sep 24, 2024

Conversation

RMCampos
Copy link
Contributor

@RMCampos RMCampos commented Aug 30, 2024

Description

Closes #1401

Changelog

Changed

  • How GW values are calculated;

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@RMCampos RMCampos self-assigned this Aug 30, 2024
@RMCampos RMCampos marked this pull request as ready for review September 11, 2024 22:02
@RMCampos RMCampos closed this Sep 12, 2024
@RMCampos RMCampos reopened this Sep 12, 2024
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few lint issues on the FE and a few /review comments on the BE, other than that really nice job!

@RMCampos RMCampos closed this Sep 23, 2024
@RMCampos RMCampos reopened this Sep 23, 2024
@RMCampos
Copy link
Contributor Author

RMCampos commented Sep 23, 2024

Need to finish these items:

  • Review what to save in the Seedlot table column non_orchard_pollen_contam_pct;
  • Review frontend payload seedlot form to include seedlotFormSmpParentOutsideDto containing the value for the smpParentsOutside variable;
  • Review what to save in the Seedlot table column smp_success_pct regarding decimal points. Currently it should be stored integer values. But the calculation will generate decimal values, how to manage?

Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RMCampos RMCampos merged commit 545c686 into main Sep 24, 2024
24 of 26 checks passed
@RMCampos RMCampos deleted the feat/1401-differences-in-gw-and-pollen branch September 24, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔼 Differences in calculated GW when pollen contamination is applied
2 participants