Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 1495 Enhance parent tree bigquery #1617

Merged
merged 4 commits into from
Sep 25, 2024
Merged

feat: 1495 Enhance parent tree bigquery #1617

merged 4 commits into from
Sep 25, 2024

Conversation

xiaopeng0202
Copy link
Collaborator

@xiaopeng0202 xiaopeng0202 commented Sep 18, 2024 •
edited
Loading

Description

Closes #issue

Changelog

Changed

  • By filtering parent_tree data upfront in filtered_parent_tree, reduced the number of records involved in subsequent joins.
  • Ensured a few columns are indexed for faster joins and where clauses

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@craigyu
Copy link
Collaborator

craigyu commented Sep 24, 2024

love the gif

mgaseta
mgaseta approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Way faster!

RMCampos
RMCampos approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great job Xiao! What a query. Very nice 👍🏻

@xiaopeng0202 xiaopeng0202 merged commit c72b1a4 into main Sep 25, 2024
24 of 26 checks passed
@xiaopeng0202 xiaopeng0202 deleted the feat/1495-enhance-parent-tree-big-query branch September 25, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaseta mgaseta mgaseta approved these changes

@RMCampos RMCampos RMCampos approved these changes

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees

@xiaopeng0202 xiaopeng0202

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaopeng0202 @craigyu @RMCampos @mgaseta