Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Employee Records in "Stat and Reports" for Sys Admin failed to pull data on past employees #1379

Open
7 tasks
jessicahjwu opened this issue Nov 19, 2024 · 4 comments
Assignees
Labels
bug Something isn't working Priority

Comments

@jessicahjwu
Copy link
Collaborator

jessicahjwu commented Nov 19, 2024

In ticket #455, we have created an Employee Records tab in Stats and Reports for obtaining various types of PDP records for employees in PDF form. In ticket #907, it was specified that past employees should not appear in Stats and Reports except for in Employee Records. However, we have discovered that past employee records are not locatable in Employee Records tab although we can still search for the data in Audit. One example is Jeanine Manji:

Jeanine is in the past employee list:
image.png

Her records of completed conversations could not be searchable in Employee Records:
image.png

In Audit, it shows that Jeanine has at least one signed off conversation:
image.png

It is required by legislation that the employer needs to provide employee records for up to 10 years upon the termination date, and it was the business requirement for ticket #907. The current workaround for Sys Admins is to manually create the PDF from the audit log, which is not only time-consuming but also pose the risk of human errors. Please look into how we can incorporate past employee records into the Stats and Reports "Employee Records" tab so that we can easily generate PDFs for these data.
Acceptance Criteria: Anyone who has the System Administrator access in PDP can generate PDF documents on all available data (past goals, active goals, open conversations, and completed conversations) from "Employee Records" in "Stat & Reports", for both current past employees. In this ticket we are fixing the issue for past employees, as the logic is working as expected for current employees.

To test for this process:

Prior to the validation process, the tester will need to be:

  • Granted with access in Test (332842-test)
  • Granted with Sys Admin access in Test and Training
  • Completing a several actions in a few employee profiles in Test:
    Active goal(s)
    Past goal(s) - by marking "archived" or "achieved"
    Create conversations without signing off or signing off partially
    Create conversations and sign-off completely

To help the tester with the above steps, the developer will need to:

  • Create a set of credential for the tester in 332842-test, using the tester's IDIR
  • Manually remove the employee that the tester completed the above actions by adding a "date_deleted" to change the employees into "past employees". An overnight process needs to be ran in order for changes to appear
  • Notify the tester that overnight process is completed

Once the tester is notified by the developer that overnight process is done, they can go to the Test/Training environment and do the below:

  1. Go to "Stats and Reports" in "Sys Admin"
  2. Go to "Employee Records" tab
  3. Enter the employee ID of those who were manually removed, specify the search criteria for date range. Check off each item individually to ensure records to appear:
    [ ] Active Goals
    [ ] Past Goals
    [ ] Open Conversations
    [ ] Completed Conversations

The acceptance criteria is that the tester is able to:

  1. Locate a list of items related to their selection topic (active goals, past goals, open conversations, closed conversations)
  2. Have both the "bulk download" button on the top of the list and "download" button in each row
  3. Download each item individually or use the bulk download to obtain PDF files
    This is a reference to the expected outcome:

image.png

  • Once the testing has been validated, developer needs to put the employee status back to active by removing the "date_deleted" and run the process again

After test is validated in Test, developer can push the changes to Training and the same steps of the above will need to be performed again in Training. Once Training is also validated, changes need to be pushed to Prod. Meg Burrows or Zehra Pirani LeRoy will be able to check for the results for past employees in Prod as System Administrators.

@jessicahjwu jessicahjwu added the bug Something isn't working label Nov 19, 2024
@jessicahjwu jessicahjwu changed the title Employee Records for completed conversations did not include past employees Employee Records in "Stat and Reports" for Sys Admin failed to pull data on past employees Nov 22, 2024
telusdcinco added a commit that referenced this issue Dec 9, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
telusdcinco added a commit that referenced this issue Dec 9, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
telusdcinco added a commit that referenced this issue Dec 10, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
telusdcinco added a commit that referenced this issue Dec 10, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
telusdcinco added a commit that referenced this issue Dec 16, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
telusdcinco added a commit that referenced this issue Dec 16, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
telusdcinco added a commit that referenced this issue Dec 16, 2024
telusdcinco added a commit that referenced this issue Dec 16, 2024
telusdcinco added a commit that referenced this issue Dec 16, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
telusdcinco added a commit that referenced this issue Dec 16, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
telusdcinco added a commit that referenced this issue Dec 17, 2024
telusdcinco added a commit that referenced this issue Dec 17, 2024
telusdcinco added a commit that referenced this issue Dec 17, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
telusdcinco added a commit that referenced this issue Dec 17, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
@telusdcinco
Copy link
Collaborator

#1383 config change required before #1379 change can be deployed.

telusdcinco added a commit that referenced this issue Dec 18, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
telusdcinco added a commit that referenced this issue Dec 18, 2024
ZenHub #1379 - Show Past Employees in Employee Record Page
@telusdcinco
Copy link
Collaborator

MIGRATION NOTES:

Code change only.

@telusdcinco
Copy link
Collaborator

Deployed to Prod. Resolved the issue of stuck emails in the queue in #1384.

@telusdcinco
Copy link
Collaborator

@jessicahjwu

Looking backend... EE 061623 only have 4 conversations as an employee, and 4 as manager.

image.png

Out of the 4 conversations as employee, 2 were previously deleted.

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority
Projects
None yet
Development

No branches or pull requests

2 participants