Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: crunchy - default #2133

Merged
merged 24 commits into from
Oct 25, 2024
Merged

feat!: crunchy - default #2133

merged 24 commits into from
Oct 25, 2024

Conversation

mishraomp
Copy link
Collaborator

@mishraomp mishraomp commented Oct 23, 2024 •
edited by github-actions bot
Loading

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

mishraomp and others added 7 commits October 23, 2024 16:18
@mishraomp
Merge branch 'main' into feat/crunchy
5306f72
@mishraomp
feat! : adding crunchy as default.
9dbfaf2 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
fix the inputes
8014f9b 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
fix the if clause
9be0275 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
fix the if clause
cadc314 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
check if user already exist in db, before adding.
0fce9fb 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
fix the user add logic
303088c 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
DerekRoberts
DerekRoberts approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious! :D

@mishraomp
fix: convention upper case vars
921228a 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
try not upgrading crunchy
5a7d879 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
fix casing
856de8d 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
intermediate commit
e07729a 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
being bold, giving it a go
957eaec 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
adding triggers for deploy
e597cc2 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
fix syntax
089fbe1 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
fix syntax
754bfae 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
fix syntax, add missing db user param
d5eb33e 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
remove vault secrets
a2c9001 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
.kn space
afc4400 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
.kn space
5c32fcf 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp
fix db host
642b75b 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
@mishraomp mishraomp marked this pull request as ready for review October 24, 2024 21:54
@DerekRoberts DerekRoberts marked this pull request as draft October 24, 2024 22:16
@mishraomp mishraomp requested a review from jon-funk October 24, 2024 22:46
@mishraomp
Copy link
Collaborator Author

mishraomp commented Oct 24, 2024 •
edited
Loading

@jon-funk , please let me know your feedback as well :), though after my first kick, @DerekRoberts will add his special sauce of reusable GHA, but lets make sure this looks good as we would port it to C&E space, as well

@mishraomp
Copy link
Collaborator Author

closing to test pr close workflow

@mishraomp mishraomp closed this Oct 24, 2024
@mishraomp mishraomp reopened this Oct 24, 2024
@mishraomp mishraomp marked this pull request as ready for review October 25, 2024 00:03
@mishraomp mishraomp merged commit 58e34f3 into main Oct 25, 2024
48 checks passed
@mishraomp mishraomp deleted the feat/crunchy branch October 25, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekRoberts DerekRoberts DerekRoberts approved these changes

@jon-funk jon-funk Awaiting requested review from jon-funk

Assignees
No one assigned
Labels
None yet
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mishraomp @DerekRoberts