21537 - Shortname Refunds - PUT and GET methods #1758
+589
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
requested review from
Jxio,
ochiu and
rodrigo-barraza
as code owners
seeker25
commented
Sep 20, 2024
| @@ -137,7 +137,7 @@ def create_shortname_refund(history: EFTShortnameHistory, **kwargs) -> EFTShortn | |||
| is_processing=history.is_processing, | |||
| short_name_id=history.short_name_id, | |||
| eft_refund_id=history.eft_refund_id, | |||
| transaction_date=EFTShortnameHistorical.transaction_date_now(), | |||
| transaction_date=EFTShortNameHistorical.transaction_date_now(), | |||
There was a problem hiding this comment.
Yikes, I'll put this back to EFTShortnameHistorical
|
Looks good so far! Thanks! |
ochiu
reviewed
Sep 20, 2024
| refund = EFTRefundModel.find_pending_refund(refund_id) | ||
| refund.comment = data.comment | ||
| refund.decline_reason = data.declined_reason | ||
| refund.status = data.status |
There was a problem hiding this comment.
We will need some additional logic when declining.
- The funds removed from the credits will have to be put back.
- History record status needs to be updated - amount can stay the same for history purposes and the UI will automatically display what is relevant for history status.
Feel free to just add # TODO and I can follow up on this
There was a problem hiding this comment.
whoops forgot, I'll add it in
ochiu
approved these changes
Sep 20, 2024
Jxio
approved these changes
Sep 20, 2024
seeker25
commented
Sep 20, 2024
| @@ -71,6 +71,7 @@ notes=FIXME,XXX,TODO | |||
| ignored-modules=flask_sqlalchemy,sqlalchemy,SQLAlchemy,alembic,scoped_session | |||
| ignored-classes=scoped_session | |||
| min-similarity-lines=15 | |||
| max-attributes=15 | |||
There was a problem hiding this comment.
I think 7 was a bit too low, 15 is reasonable.. for some of our larger search dataclasses
seeker25
commented
Sep 20, 2024
| status=EFTShortnameRefundStatus.APPROVED.value | ||
| ).to_dict(), 'valid_full_patch_refund', Role.EFT_REFUND_APPROVER.value), | ||
| ({}, 'unauthorized', Role.EFT_REFUND.value), | ||
| (EFTShortNameRefundPatchRequest( |
There was a problem hiding this comment.
a bit of a new style of test, using objects that are serialized..
seeker25
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#21537
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).