Allow multiple calls to FinishWith. Re: #115.

HISTORY.md

@@ -1,6 +1,7 @@
 ## v21.0.5
 * Better error support.
 * Added `Person.FullName` field.
+* Allowed `Faker<T>.FinishWith` to be called multiple times. Last call wins.
 
 ## v21.0.4
 * Fixed `f.Image` URL generation.

Source/Bogus.Tests/GitHubIssues/Issue115.cs

@@ -2,11 +2,19 @@
 using Bogus.Tests.Models;
 using FluentAssertions;
 using Xunit;
+using Xunit.Abstractions;
 
 namespace Bogus.Tests.GitHubIssues
 {
-   public class Issue115
+   public class Issue115 : SeededTest
    {
+      private readonly ITestOutputHelper console;
+
+      public Issue115(ITestOutputHelper console)
+      {
+         this.console = console;
+      }
+
       public class Customer
       {
          public string Name { get; set; }
@@ -23,5 +31,35 @@ public void should_throw_with_nested_expression()
          fakerMaker.ShouldThrow<ArgumentException>();
 
       }
+
+      [Fact]
+      public void calling_finish_with_twice_is_okay()
+      {
+         var productCalled = false;
+         var colorCalled = false;
+
+         var faker = new Faker<Order>()
+            .RuleFor(o => o.OrderId, f => f.Random.Number(1,50))
+            .FinishWith((f, o) =>
+               {
+                  productCalled = true;
+                  o.Item = f.Commerce.Product();
+               })
+            .FinishWith((f, o) =>
+               {
+                  colorCalled = true;
+                  o.Item = f.Commerce.Color();
+               });
+
+         var order = faker.Generate();
+
+         order.Item.Should().Be("yellow");
+
+         //sanity check
+         productCalled.Should().BeFalse();
+         colorCalled.Should().BeTrue();
+
+         console.Dump(order);
+      }
    }
 }

Source/Bogus/Faker[T].cs

@@ -330,7 +330,7 @@ public virtual Faker<T> FinishWith(Action<Faker, T> action)
                Action = action,
                RuleSet = currentRuleSet
             };
-         this.FinalizeActions.Add(currentRuleSet, rule);
+         this.FinalizeActions[currentRuleSet] = rule;
          return this;
       }