chore: update README

bcnmy · Aug 29, 2024 · d850fc6 · d850fc6
1 parent 1337f97
commit d850fc6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/account/BaseSmartContractAccount.ts b/src/account/BaseSmartContractAccount.ts
@@ -278,7 +278,7 @@ export abstract class BaseSmartContractAccount<
     return this.entryPointAddress
   }
 
-  async isAccountDeployed(forceFetch = false): Promise<boolean> {
+  async isAccountDeployed(): Promise<boolean> {
     return (await this.getDeploymentState()) === DeploymentState.DEPLOYED
   }
 

diff --git a/tests/src/README.md b/tests/src/README.md
@@ -1,4 +1,4 @@
-# @biconomy/sdk Testing Guide
+# @biconomy/sdk Testing Framework
 
 ## Testing Setup
 
@@ -35,11 +35,11 @@ To prevent tests from conflicting with one another, networks can be scoped at th
 - Tests within the same file using a local network may conflict with each other. If needed, split tests into separate files or use the Test Scope.
 
 ### Test Scope
-- A network is spun up *only* for the individual test in which it is used. Access this via the `isolatedTest` helper in the same file as `"COMMON_LOCALHOST"` or `"FILE_LOCALHOST"` network types.
+- A network is spun up *only* for the individual test in which it is used. Access this via the `localhostTest` helper in the same file as `"COMMON_LOCALHOST"` or `"FILE_LOCALHOST"` network types.
 
 Example usage:
 ```typescript
-isolatedTest("should be used in the following way", async({ config: { bundlerUrl, chain, fundedClients }}) => {
+localhostTest("should be used in the following way", async({ config: { bundlerUrl, chain, fundedClients }}) => {
     // chain, bundlerUrl spun up just in time for this test only...
     expect(await fundedClients.smartAccount.getAccountAddress()).toBeTruthy();
 });
@@ -57,9 +57,9 @@ isolatedTest("should be used in the following way", async({ config: { bundlerUrl
 
 Example usage:
 ```typescript
-testnetTest("should be used in the following way", async({ config: { bundlerUrl, chain, fundedClients }}) => {
+testnetTest("should be used in the following way", async({ config: { bundlerUrl, chain, account }}) => {
     // chain, bundlerUrl etc taken from environment variables...
-    expect(await fundedClients.smartAccount.getAccountAddress()).toBeTruthy();
+    expect(account).toBeTruthy(); // from private key, please ensure it is funded if sending txs
 });
 ```
 

diff --git a/tests/src/testSetup.ts b/tests/src/testSetup.ts
@@ -12,7 +12,7 @@ export type NetworkConfigWithTestClients = NetworkConfigWithBundler & {
   fundedTestClients: FundedTestClients
 }
 
-export const isolatedTest = test.extend<{
+export const localhostTest = test.extend<{
   config: NetworkConfigWithTestClients
 }>({
   // biome-ignore lint/correctness/noEmptyPattern: Needed in vitest :/