Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC 7779 support #231

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

ERC 7779 support #231

wants to merge 7 commits into from

Conversation

filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Dec 18, 2024

Draft implementation of ERC-7779 support for Nexus


PR-Codex overview

This PR focuses on enhancing the Nexus smart contract by integrating the ERC7779Adapter, implementing storage management for redelegation, and adding event emissions for module uninstallations.

Detailed summary

  • Added _amIERC7702 function in BaseAccount for checking contract type.
  • Introduced MockERC7779 for testing ERC7779Adapter.
  • Updated IModuleManagerEventsAndErrors with new events.
  • Changed _STORAGE_LOCATION to _NEXUS_STORAGE_LOCATION in Storage.
  • Modified INexus interface to include IERC7779.
  • Created TestFuzz_ERC7779Adapter for testing storage addition.
  • Defined IERC7779 interface for storage base management.
  • Added redelegation logic in TestEIP7702.
  • Implemented ERC7779Adapter with storage handling and redelegation functions.
  • Expanded ModuleManager with uninstall functions for validators, executors, and hooks.
  • Updated Nexus contract to inherit from ERC7779Adapter and manage redelegation logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

openzeppelin-code bot commented Dec 18, 2024

ERC 7779 support

Generated at commit: 779d85d5498bf212e0b304468e20278565667251

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
27
35

For more details view the full report in OpenZeppelin Code Inspector

Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L185

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant