Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed fs-symlink dependency. #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed fs-symlink dependency. #5

wants to merge 1 commit into from

Conversation

geskill
Copy link

@geskill geskill commented Apr 18, 2017 •
edited
Loading

  • The link to be created is never used (i don't see where)
  • The fs-symlink requires admin access if not => UnhandledPromiseRejectionWarning because of Node 6+

If required by someone, we can create flag to use it or not

@clementbrunel clementbrunel mentioned this pull request Apr 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@geskill