Declare compatibility with BitIntegers 0.3 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But continue to allow 0.2 as well. BitIntegers 0.3 made some changes to promotion rules but those don't affect us (as is evidenced by tests passing). They'll only possibly affect downstream users who forget to `decode` the `Int24` signals.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
- Coverage 95.59% 95.25% -0.34%
==========================================
Files 4 4
Lines 295 295
==========================================
- Hits 282 281 -1
- Misses 13 14 +1 ☔ View full report in Codecov by Sentry. |
palday
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But continue to allow 0.2 as well. BitIntegers 0.3 made some changes to promotion rules but those don't affect us (as is evidenced by tests passing). They'll only possibly affect downstream users who forget to
decodetheInt24signals.