fix doctest script #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericphanson
commented
Aug 19, 2021
| @@ -26,8 +42,10 @@ jobs: | |||
| - uses: codecov/codecov-action@v1 | |||
| with: | |||
| file: lcov.info | |||
| token: ${{ secrets.CODECOV_TOKEN }} | |||
There was a problem hiding this comment.
Not needed for public repos I think:
Suggested change
| token: ${{ secrets.CODECOV_TOKEN }} |
|
Looks like this might be able to be bundled into a single action: julia-actions/julia-fix-doctests#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we run two jobs:
diff_contextwhich is the default, and generates github suggestions. However it only looks at the diff-- any doctests failing elsewhere are ignored.nofiltercontext and can only make "annotations" (like codecov). These you can toggle visibility by pressing "a". They aren't committable, just for awareness. The workflow will fail if there are any annotations, i.e. any changed doctests.The previous way was only the first job.
I experimented with this on an internal repo, though I should've done it on a public one so everyone can see the experiments.
This addresses @christopher-dG's concern in #18 (comment).