Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export assumes value field is present in the annotations #54

Open
kleinschmidt opened this issue Jul 19, 2022 · 0 comments
Open

export assumes value field is present in the annotations #54

kleinschmidt opened this issue Jul 19, 2022 · 0 comments
Assignees

Comments

@kleinschmidt
Copy link
Member

In the brave new world of Legolas schemas for annotations, the annotations table is only required to have recording, id, and span columns. Previous iterations of Beacon's annotation format also had a value field, but that's no longer universally true. The current export code fails on those tables (where the relevant "value" information is recorded in a field with a different name). I think what we should do is

  • Implement a schema for EDF annotations as generated during import
  • Implement a schema for the minimum fields required for export, and validate the input annotations during export.

From a very quick perusal of the code, the same schema could be used for both (the import puts the the zero or more strings in .annotations field of the EDF annotation into the value field of one or more Onda.Annotations), so we could define

Legolas.@row("edf.annotation@1" > "onda.annotation@1", value::String=string(value))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant