use EDFAnnotation schema for import/export #55
Conversation
| EDF file. The only extra field is `value`, which holds the string stored in the | ||
| elements of `annotations` in the EDF annotation. | ||
| """ | ||
| const EDFAnnotation = @row("edf.annotation@1" > "onda.annotation@1", |
There was a problem hiding this comment.
In following the convention for Plan shouldn't this be?
| const EDFAnnotation = @row("edf.annotation@1" > "onda.annotation@1", | |
| const Annotation = @row("ondaedf.annotation@1" > "onda.annotation@1", |
There was a problem hiding this comment.
I think my intention here was that this is an annotation that is derived from an EDF Annotation signal. The fact that it's imported by OndaEDF seems a bit beside the point (unlike the plan which is intrinsically an OndaEDF thing)
| @@ -38,6 +38,7 @@ jobs: | |||
| path: ~/.julia/artifacts | |||
| key: ${{ runner.os }}-test-artifacts-${{ hashFiles('**/Project.toml') }} | |||
| restore-keys: ${{ runner.os }}-test-artifacts | |||
| - run: julia --project -e 'using Pkg; Pkg.develop([PackageSpec(; path="OndaEDFSchemas.jl")])' | |||
There was a problem hiding this comment.
Should only be needed until OndaEDFSchemas.jl is registered. My personal preference would be to have this work split into two PRs. Also, I do find using a committed Manifest.toml is a cleaner way to do that but mainly that's only useful while developing the PR
There was a problem hiding this comment.
I think it is registered at this point. Without this the registered version is picked up, which means that the OndaEDF CI will not pick up the OndaEDFSchemas changes in a PR.
|
we're going to do this as part of the Legolas 0.5 upgrade #60 |
This fixes #54 by enforcing this assumption with a schema (
edf.annotation) which extendsonda.annotationwith one extra fieldvalue::String. It also changes the return type of imported EDF annotation to these rows (although the values are identical); while this is technically breaking, it seems pretty harmless.